From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB506C352BE for ; Thu, 16 Apr 2020 07:27:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C4B321556 for ; Thu, 16 Apr 2020 07:27:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fyqvqiMY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439237AbgDPH1c (ORCPT ); Thu, 16 Apr 2020 03:27:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2439143AbgDPH1b (ORCPT ); Thu, 16 Apr 2020 03:27:31 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCFAC061A0C for ; Thu, 16 Apr 2020 00:27:30 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id j2so3551917wrs.9 for ; Thu, 16 Apr 2020 00:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U8AKWUzItg4HdWG6JpT726BnWeBSPcROVZ9cqP+1HlA=; b=fyqvqiMYltvStlD2Vm2BPl597p42K3MeXn79E4X3k+Apxe608DMoOLD8vVJsd1dvWT P49teuDbDwy7fOdGMCHmXctl8ZprgvpNP7jaqAz3ZPS4QhVz4INMqxXHxlQRpUIoF2sh XibXf1PM2LTvRsN/YNQ2pWeyEIvkL3ZnwcE2tUC893x3h6pt7jrdDnbn0QD16YlDel5G nWFyJ4diiVeF9mprFrOYUrzGQMqdBhy6WKPeh8TwWaFtlS+PdoLIxg/kNGir+jfPef6G gV5qrMhq8Nv4uwz87156PwJ8Pc80Bga1joBV2Lu3Pe81hdU8Q67JCnX1e0fVxRNXwRTs QkbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U8AKWUzItg4HdWG6JpT726BnWeBSPcROVZ9cqP+1HlA=; b=PqK3m+LMr76jWnwPlDgZ5jy98dlVVEYddls2Ero3XKS3L6HeDwG3yhxcxaMEUu/9KG JcjLbpLwOGWttnuT9Wgd/5/ZlVOS9xjtk+JagByF4+Lsje4uReK3epCKX8vgq9fOqCwW 3HEfPgzcQoeHykgjTJwvUuzfWHoOfCbwVLNl5nKf4M+R4mTsI4DOqNyXeQj9NLirJDGB 9XPhIiTlBCYUa4QCBL6lPppSdbJ0LKyEUnHYoTMxy2rWxUquA6mKZg9ZNu1sw1RDCTL0 v6jSSsDFgWIqyvVGpeSskGQjpm9fVTxUBkiOgFNH0wkNQ1mBUnNImjlKIeQ5fsz7fOz6 vxTw== X-Gm-Message-State: AGi0Puam6tkeGpWgKiYF0iBk0YTriDCSLTI1jyBcjOR9V5cf3Y1U5mbm VoAe4wDEG1QUSWrRjeCPeNb+oA== X-Google-Smtp-Source: APiQypIjlhz+XjqBwEJ4FV4yPSk0fGDYE43Q42V8vukOgrbgmUQzAFgB3JhwTJCG9YW/rYXrnYjFDQ== X-Received: by 2002:a05:6000:8b:: with SMTP id m11mr19131706wrx.168.1587022048717; Thu, 16 Apr 2020 00:27:28 -0700 (PDT) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id s14sm2681883wme.33.2020.04.16.00.27.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2020 00:27:28 -0700 (PDT) Subject: Re: [PATCH 1/2] dt-bindings: ASoC: qdsp6: Suggest more generic node names To: Stephan Gerhold , Rob Herring Cc: Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org References: <20200415081159.1098-1-stephan@gerhold.net> From: Srinivas Kandagatla Message-ID: <2000e307-ecab-95b2-55e1-cd368b9759d9@linaro.org> Date: Thu, 16 Apr 2020 08:27:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200415081159.1098-1-stephan@gerhold.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/04/2020 09:11, Stephan Gerhold wrote: > Change the listed examples to use more generic node names, representing > the class of the device nodes: > > - apr-service@ > - dai@ > > Both names are already in use in arch/arm64/boot/dts/qcom/sdm845.dtsi. > > Also add #address-cells + #size-cells to the q6asm example, > without them the example produces dtc warnings. > > Cc: Srinivas Kandagatla > Signed-off-by: Stephan Gerhold Reviewed-by: Srinivas Kandagatla > --- > .../devicetree/bindings/sound/qcom,q6adm.txt | 2 +- > .../devicetree/bindings/sound/qcom,q6afe.txt | 46 +++++++++---------- > .../devicetree/bindings/sound/qcom,q6asm.txt | 7 ++- > .../devicetree/bindings/sound/qcom,q6core.txt | 2 +- > 4 files changed, 30 insertions(+), 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6adm.txt b/Documentation/devicetree/bindings/sound/qcom,q6adm.txt > index bbae426cdfb1..15c353a20de8 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6adm.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,q6adm.txt > @@ -29,7 +29,7 @@ used by the apr service device. > Definition: Must be 0 > > = EXAMPLE > -q6adm@8 { > +apr-service@8 { > compatible = "qcom,q6adm"; > reg = ; > q6routing: routing { > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > index d74888b9f1bb..4916dd6a0896 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > @@ -100,7 +100,7 @@ configuration of each dai. Must contain the following properties. > > = EXAMPLE > > -q6afe@4 { > +apr-service@4 { > compatible = "qcom,q6afe"; > reg = ; > > @@ -110,12 +110,12 @@ q6afe@4 { > #address-cells = <1>; > #size-cells = <0>; > > - hdmi@1 { > - reg = <1>; > + dai@1 { > + reg = ; > }; > > - tdm@24 { > - reg = <24>; > + dai@24 { > + reg = ; > qcom,tdm-sync-mode = <1>: > qcom,tdm-sync-src = <1>; > qcom,tdm-data-out = <0>; > @@ -125,8 +125,8 @@ q6afe@4 { > > }; > > - tdm@25 { > - reg = <25>; > + dai@25 { > + reg = ; > qcom,tdm-sync-mode = <1>: > qcom,tdm-sync-src = <1>; > qcom,tdm-data-out = <0>; > @@ -135,43 +135,43 @@ q6afe@4 { > qcom,tdm-data-align = <0>; > }; > > - prim-mi2s-rx@16 { > - reg = <16>; > + dai@16 { > + reg = ; > qcom,sd-lines = <0 2>; > }; > > - prim-mi2s-tx@17 { > - reg = <17>; > + dai@17 { > + reg = ; > qcom,sd-lines = <1>; > }; > > - sec-mi2s-rx@18 { > - reg = <18>; > + dai@18 { > + reg = ; > qcom,sd-lines = <0 3>; > }; > > - sec-mi2s-tx@19 { > - reg = <19>; > + dai@19 { > + reg = ; > qcom,sd-lines = <1>; > }; > > - tert-mi2s-rx@20 { > - reg = <20>; > + dai@20 { > + reg = ; > qcom,sd-lines = <1 3>; > }; > > - tert-mi2s-tx@21 { > - reg = <21>; > + dai@21 { > + reg = ; > qcom,sd-lines = <0>; > }; > > - quat-mi2s-rx@22 { > - reg = <22>; > + dai@22 { > + reg = ; > qcom,sd-lines = <0>; > }; > > - quat-mi2s-tx@23 { > - reg = <23>; > + dai@23 { > + reg = ; > qcom,sd-lines = <1>; > }; > }; > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt > index 9f5378c51686..6b9a88d0ea3f 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt > @@ -51,13 +51,16 @@ configuration of each dai. Must contain the following properties. > > = EXAMPLE > > -q6asm@7 { > +apr-service@7 { > compatible = "qcom,q6asm"; > reg = ; > q6asmdai: dais { > compatible = "qcom,q6asm-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > #sound-dai-cells = <1>; > - mm@0 { > + > + dai@0 { > reg = <0>; > direction = <2>; > is-compress-dai; > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6core.txt b/Documentation/devicetree/bindings/sound/qcom,q6core.txt > index 7f36ff8bec18..5cd4cc9b1fde 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6core.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,q6core.txt > @@ -15,7 +15,7 @@ used by the apr service device. > example "qcom,q6core-v2.0" > > = EXAMPLE > -q6core@3 { > +apr-service@3 { > compatible = "qcom,q6core"; > reg = ; > }; >