public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Dragan Simic <dsimic@manjaro.org>
Cc: linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Move L3 cache under CPUs in RK356x SoC dtsi
Date: Thu, 26 Sep 2024 10:48:03 +0200	[thread overview]
Message-ID: <2007608.CrzyxZ31qj@phil> (raw)
In-Reply-To: <57d360d73054d1bad8566e3fe0ee1921@manjaro.org>

Am Donnerstag, 26. September 2024, 10:32:17 CEST schrieb Dragan Simic:
> Hello Heiko,
> 
> On 2024-09-26 10:24, Heiko Stuebner wrote:
> > Am Donnerstag, 26. September 2024, 09:49:18 CEST schrieb Dragan Simic:
> >> Move the "l3_cache" node under the "cpus" node in the dtsi file for 
> >> Rockchip
> >> RK356x SoCs.  There's no need for this cache node to be at the higher 
> >> level.
> >> 
> >> Fixes: 8612169a05c5 ("arm64: dts: rockchip: Add cache information to 
> >> the SoC dtsi for RK356x")
> >> Cc: stable@vger.kernel.org
> > 
> > I think the commit message needs a bit more rationale on why this is a
> > stable-worthy fix. Because from the move and commit message it reads
> > like a styling choice ;-) .
> > 
> > I do agree that it makes more sense as child of cpus, but the commit
> > message should also elaborate on why that would matter for stable.
> 
> Thanks for your feedback!  Perhaps it would be the best to simply drop 
> the
> submission to stable kernels...  Believe it or not, :) I spent a fair 
> amount
> of time deliberating over the submission to stable, but now I think it's
> simply better to omit that and not increase the amount of patches that 
> go
> into stable unnecessary.
> 
> Would you like me to send the v2 with no Cc to stable, or would you 
> prefer
> to drop that line yourself?

I'm hopeful that I'll remember to drop it :-), so I guess no need
to resend for that.

Heiko



  reply	other threads:[~2024-09-26  8:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26  7:49 [PATCH] arm64: dts: rockchip: Move L3 cache under CPUs in RK356x SoC dtsi Dragan Simic
2024-09-26  8:24 ` Heiko Stuebner
2024-09-26  8:32   ` Dragan Simic
2024-09-26  8:48     ` Heiko Stuebner [this message]
2024-09-26  9:24 ` Robin Murphy
2024-09-26  9:36   ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2007608.CrzyxZ31qj@phil \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox