Re: [PATCH 2/8] Add conditionalized debug() print macro.

[Josh Boyer <jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

On Tue, 23 Sep 2008 14:04:06 -0500
Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org> wrote:

> From: Jon Loeliger <jdl-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> Signed-off-by: Jon Loeliger <jdl-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  dtc.h |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/dtc.h b/dtc.h
> index 08d54c8..ec636f8 100644
> --- a/dtc.h
> +++ b/dtc.h
> @@ -34,7 +34,15 @@
>  #include <libfdt_env.h>
>  #include <fdt.h>
> 
> +#ifdef DEBUG
> +#define debug(fmt,args...)	printf(fmt, ##args)
> +#else
> +#define debug(fmt,args...)
> +#endif
> +
> +

So, not to be nitpicky, but this requires a rebuild of dtc with -DDEBUG
(or similar) to get the debug output.

Would it be better to have it just take a --debug option on the command
line and conditionalize on a global variable?  dtc isn't exactly a
performance crazy application, so the if checks shouldn't matter too
much.

josh