From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH] Fix an overflow case in fdt_offset_ptr() detected by GCC 4.3. Date: Tue, 30 Sep 2008 12:39:34 +1000 Message-ID: <20080930023934.GB8939@yookeroo.seuss> References: <1222358537.25112.7.camel@ld0161-tx32> <20080930011525.GB6189@yookeroo.seuss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Jon Loeliger Cc: devicetree-discuss , Stephen Papacharalambous List-Id: devicetree@vger.kernel.org On Mon, Sep 29, 2008 at 08:51:02PM -0500, Jon Loeliger wrote: > > On Mon, Sep 29, 2008 at 04:13:27PM -0500, Jon Loeliger wrote: > > > > > > > > Uh.. Jon.. did you see my reply to this. I'm not at all convinced > > this patches a real problem. I suspect it's just replacing a problem > > that gcc could detect with a similar one that gcc can't (and for which > > we already had a test to deal with, anyway). > > I saw your reply, and you are welcome to read up > on the fist fight over in GCC land too. > > In the meantime, it fixes a real problem that we > have at Freescale. Ok.. and can you explain this real problem? If this is just to work around a silly gcc warning that appears in some circumstances and not others, that's fine, but the commit message should say so. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson