From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH 9/9 V3] Test constant expressions in cell contexts. Date: Tue, 30 Sep 2008 16:04:18 +1000 Message-ID: <20080930060418.GD18695@yookeroo.seuss> References: <1222460748-20127-1-git-send-email-jdl@jdl.com> <1222460748-20127-2-git-send-email-jdl@jdl.com> <1222460748-20127-3-git-send-email-jdl@jdl.com> <1222460748-20127-4-git-send-email-jdl@jdl.com> <1222460748-20127-5-git-send-email-jdl@jdl.com> <1222460748-20127-6-git-send-email-jdl@jdl.com> <1222460748-20127-7-git-send-email-jdl@jdl.com> <1222460748-20127-8-git-send-email-jdl@jdl.com> <1222460748-20127-9-git-send-email-jdl@jdl.com> <1222460748-20127-10-git-send-email-jdl@jdl.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1222460748-20127-10-git-send-email-jdl-CYoMK+44s/E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Jon Loeliger Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Sep 26, 2008 at 03:25:48PM -0500, Jon Loeliger wrote: > From: Jon Loeliger > > This code is derived from code posted by David Gibson. [snip] > + for (i = 0; i < ARRAY_SIZE(expr_table); i++) > + if (fdt32_to_cpu(res[i]) != expr_table[i].result) Hrm.. when you fixed the endian bug here (I found it myself the other day), you might have thought to fix it... > + FAIL("Incorrect result for expression \"%s\"," > + " 0x%x instead of 0x%x\n", > + expr_table[i].expr, res[i], ^^^^^^ ...here, too. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson