Re: [PATCH] Remove support for the legacy DTS source file format.

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

On Fri, Oct 03, 2008 at 04:17:09PM -0500, Jon Loeliger wrote:
> Now that all in-kernel-tree DTS files are properly /dts-v1/,
> remove direct support for the older, un-numbered DTS
> source file format.
> 
> Convert existing tests to /dts-v1/ and remove support
> for the conversion tests themselves.
> 
> For now, though, the conversion tool still exists.
> 
> Signed-off-by: Jon Loeliger <jdl-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> 
> I've decided to apply this patch.  It may not be popular,
> but we're going to move forward here.   Several folks at
> Freescale agree with me here.

As you no doubt expected, I'm not very happy with this.

Updating the test dts files to v1 certainly makes sense.  We probably
should have done that some time ago.  *Except* that you've converted
the *_dts0.dts files, which makes no sense since their only purpose
was to test the handling of dtsv0 files.  This is sloppy, if v0
support is removed from they should be deleted (along with the
corresponding pieces of run_tests.sh).

Removing the actual v0 support I think is premature, but I guess we
can agree to disagree on this point.

Removing the conversion tests worries me more, however, since I fear
that convert-dtsv0 will start bitrotting without testcases to keep it
in line.  If I get time I might see about a patch which restore at
least some of these tests in a way that doesn't require v0 support in
dtc itself (possibly including prebuilt dtbs for comparison).

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson