From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss
<devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
Subject: Re: DTS language enhancements
Date: Thu, 9 Oct 2008 10:08:50 -0500 [thread overview]
Message-ID: <20081009150850.GA30900@ld0162-tx32.am.freescale.net> (raw)
In-Reply-To: <20081009022722.GC7997-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
On Thu, Oct 09, 2008 at 01:27:22PM +1100, David Gibson wrote:
> On Tue, Oct 07, 2008 at 11:50:38AM -0500, Scott Wood wrote:
> > On Tue, Oct 07, 2008 at 12:41:03PM +1100, David Gibson wrote:
> > > > Instead of /addnode/, how about an alternate version of (or option to)
> > > > /merge/ that merges the second tree with the contents of the first,
> > >
> > > Um.. I don't entirely see how this variant of /merge/ would differ
> > > from /addnode/.
> >
> > /addnode/ can only add one node at a time, and has an different syntax
> > than normal for representing the node to be added (name is split from
> > body). /mergeunder/ could add any number of nodes and/or properties,
> > and would use more normal syntax.
>
> Um.. in that case I don't see how this differs from the original
> /merge/.
I guess the issue is that /merge/ is incompletely specified. The example
showed it taking anonymous trees as parameters; are the parameters always
wrapped as such, or can named nodes be passed directly? In the latter
case, /mergeunder/ was intended as a way of dereferencing the former
argument so as to place things inside it rather than create a new
anonymous node containing both, without needing to know the
name/unit-address of the named node.
An alternative would be a function to extract the name of non-anonymous
nodes, which could be used to build a matching subnode in the second
/merge/ argument.
> > We probably should have added comma-delimiting when we switched to
> > decimal-by-default.
>
> Maybe, but its done now. I really don't think requiring parens aroud
> expressions is that big an imposition.
Agreed; I may find it as ugly as you find identifier prefixes, but we
don't have much of a choice if we want to retain compatibility.
-Scott
prev parent reply other threads:[~2008-10-09 15:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 4:37 DTS language enhancements David Gibson
[not found] ` <20081003043710.GH3002-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-03 5:08 ` Kumar Gala
[not found] ` <FB6717CF-EF47-40E1-B972-1E642066D5C6-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2008-10-03 5:29 ` David Gibson
2008-10-03 14:07 ` Jon Loeliger
[not found] ` <48E62739.8090109-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2008-10-04 4:18 ` David Gibson
2008-10-06 17:06 ` Scott Wood
[not found] ` <20081006170601.GA31967-VKaLA/mbEU932VTgPCOETVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2008-10-07 1:41 ` David Gibson
[not found] ` <20081007014103.GA23135-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-07 4:17 ` David Gibson
[not found] ` <20081007041725.GD19037-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-07 16:46 ` Scott Wood
2008-10-07 16:50 ` Scott Wood
[not found] ` <20081007165038.GA17126-VKaLA/mbEU932VTgPCOETVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2008-10-09 2:27 ` David Gibson
[not found] ` <20081009022722.GC7997-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-09 15:08 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009150850.GA30900@ld0162-tx32.am.freescale.net \
--to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox