From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: generating a phandle w/libfdt? Date: Fri, 7 Nov 2008 11:02:08 +1100 Message-ID: <20081107000208.GD6692@yookeroo.seuss> References: <4BE3ADDA-362B-43AE-8D05-11260B94CD13@kernel.crashing.org> <9696D7A991D0824DBA8DFAC74A9C5FA3047947A3@az33exm25.fsl.freescale.net> <20081026234052.GB22339@yookeroo.seuss> <76BF0CED-6848-43B9-8035-FC9C1F1DD981@kernel.crashing.org> <20081028000449.GB26424@yookeroo.seuss> <33A5285E-F5BE-4109-9C29-59F23E6264A0@kernel.crashing.org> <20081106021040.GJ28465@yookeroo.seuss> <9696D7A991D0824DBA8DFAC74A9C5FA304840D5C@az33exm25.fsl.freescale.net> <49137D70.8080009@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <49137D70.8080009-KZfg59tc24xl57MIdRCFDg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Scott Wood Cc: devicetree-discuss List-Id: devicetree@vger.kernel.org On Thu, Nov 06, 2008 at 05:27:44PM -0600, Scott Wood wrote: > Yoder Stuart wrote: >>> -----Original Message----- >>> From: David Gibson [mailto:david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org] Sent: >>> Wednesday, November 05, 2008 8:11 PM >>> To: Kumar Gala >>> Cc: Yoder Stuart-B08248; devicetree-discuss >>> Subject: Re: generating a phandle w/libfdt? >>> >>> You know, I am inclined to make: >>> linux,phandle = < &thisnode >; >>> the approved way of doing this. I *think* that will already work, but >>> if not we can fix it. The circular reference is slightly odd, but it >>> is self-consistent. I suppose we could still come up with a further >>> shorthand so it's not necessary to make a label for a node to do this >>> ('&.' or something for 'reference-to-containing-node'). >> >> As I mentioned earlier in this thread, this _does_ work and is >> what we did in the DTS to get phandles generated for nodes that were >> going to be referenced by nodes dynamically created later. > > It works if you call the property something *other* than linux,phandle. > > If you explicitly say linux,phandle = <&self> then you get this: > ERROR (explicit_phandles): /chosen has invalid linux,phandle value > 0xffffffff Well, I guess I'd better fix that, then. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson