From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Boyer Subject: Re: [PATCH 1/2] libfdt: Add version.lds file Date: Tue, 25 Nov 2008 20:57:18 -0500 Message-ID: <20081125205718.68a92b73@zod.rchland.ibm.com> References: <20081125142149.GB2340@yoda.jdub.homelinux.org> <20081125165747.GB17258@yoda.jdub.homelinux.org> <20081125171648.GC17258@yoda.jdub.homelinux.org> <20081126014753.GF3420@yookeroo.seuss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081126014753.GF3420-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: David Gibson Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 26 Nov 2008 12:47:53 +1100 David Gibson wrote: > > The hard-coded list is pretty simple, at the risk of missing things. > > I'm actually not too wirried about missing things. If we miss > something, it's pretty easy to fix. It probably would be a good idea > to make the testsuite build against the shared version of the library > to verify that at least the functions exercised there are correctly > exposed. That's a good idea. I'll see what I can do there. > I'm marginally more worried about an overbroad wildcard including > something we didn't really want exposed. I think the versioning > script needs a: > local: > * > after the global list to to inhibit exposing everything else. Ah, yes. It would be good for someone with more of a clue than me to vet the list I have in the file right now, and make sure I didn't include/omit things that shouldn't/should be there. Once that is done, I can do the local thing. josh