Re: [PATCH 1/2] libfdt: Add version.lds file

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

On Tue, Nov 25, 2008 at 08:57:18PM -0500, Josh Boyer wrote:
> On Wed, 26 Nov 2008 12:47:53 +1100
> David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> 
> > > The hard-coded list is pretty simple, at the risk of missing things.
> > 
> > I'm actually not too wirried about missing things.  If we miss
> > something, it's pretty easy to fix.  It probably would be a good idea
> > to make the testsuite build against the shared version of the library
> > to verify that at least the functions exercised there are correctly
> > exposed.
> 
> That's a good idea.  I'll see what I can do there.
> 
> > I'm marginally more worried about an overbroad wildcard including
> > something we didn't really want exposed.  I think the versioning
> > script needs a:
> > 	local:
> > 		*
> > after the global list to to inhibit exposing everything else.
> 
> Ah, yes.  It would be good for someone with more of a clue than me to
> vet the list I have in the file right now, and make sure I didn't
> include/omit things that shouldn't/should be there.  Once that is done,
> I can do the local thing.

Oh, sorry forgot to add, everything on your list so far looks like it
should be exposed.  Omissions I'll need to look more carefully.  But
if the testsuite builds against it we should be pretty right.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson