From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
pali.rohar@gmail.com
Subject: Re: [RFC 01/18] omap3isp: Fix error handling in probe
Date: Sun, 08 Mar 2015 01:17:40 +0200 [thread overview]
Message-ID: <2008156.hkDykbnpAV@avalon> (raw)
In-Reply-To: <1425764475-27691-2-git-send-email-sakari.ailus@iki.fi>
Hi Sakari,
Thank you for the patch.
On Saturday 07 March 2015 23:40:58 Sakari Ailus wrote:
> The mutex was not destroyed correctly if dma_coerce_mask_and_coherent()
> failed for some reason.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/omap3isp/isp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap3isp/isp.c
> b/drivers/media/platform/omap3isp/isp.c index deca809..fb193b6 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -2252,7 +2252,7 @@ static int isp_probe(struct platform_device *pdev)
>
> ret = dma_coerce_mask_and_coherent(isp->dev, DMA_BIT_MASK(32));
> if (ret)
> - return ret;
> + goto error;
>
> platform_set_drvdata(pdev, isp);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-03-07 23:17 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 21:40 [RFC 00/18] Device tree support for omap3isp, N9[50] primary camera Sakari Ailus
2015-03-07 21:40 ` [RFC 02/18] omap3isp: Avoid a BUG_ON() in media_entity_create_link() Sakari Ailus
2015-03-07 23:19 ` Laurent Pinchart
2015-03-07 21:41 ` [RFC 07/18] omap3isp: Rename regulators to better suit the Device Tree Sakari Ailus
2015-03-07 23:26 ` Laurent Pinchart
2015-03-07 21:41 ` [RFC 08/18] omap3isp: Calculate vpclk_div for CSI-2 Sakari Ailus
2015-03-07 23:27 ` Laurent Pinchart
[not found] ` <1425764475-27691-1-git-send-email-sakari.ailus-X3B1VOXEql0@public.gmane.org>
2015-03-07 21:40 ` [RFC 01/18] omap3isp: Fix error handling in probe Sakari Ailus
2015-03-07 23:17 ` Laurent Pinchart [this message]
2015-03-07 21:41 ` [RFC 03/18] omap3isp: Separate external link creation from platform data parsing Sakari Ailus
2015-03-07 23:23 ` Laurent Pinchart
2015-03-07 21:41 ` [RFC 04/18] omap3isp: DT support for clocks Sakari Ailus
2015-03-07 21:41 ` [RFC 05/18] omap3isp: Platform data could be NULL Sakari Ailus
2015-03-07 23:50 ` Laurent Pinchart
2015-03-07 21:41 ` [RFC 06/18] omap3isp: Refactor device configuration structs for Device Tree Sakari Ailus
2015-03-11 23:07 ` Laurent Pinchart
2015-03-07 21:41 ` [RFC 09/18] omap3isp: Replace mmio_base_phys array with the histogram block base Sakari Ailus
2015-03-07 23:28 ` Laurent Pinchart
2015-03-07 21:41 ` [RFC 10/18] omap3isp: Move the syscon register out of the ISP register maps Sakari Ailus
2015-03-07 23:34 ` Laurent Pinchart
2015-03-07 23:43 ` Sakari Ailus
2015-03-09 15:20 ` Tony Lindgren
2015-03-14 15:00 ` Sakari Ailus
2015-03-16 0:19 ` Laurent Pinchart
2015-03-16 23:21 ` Sakari Ailus
2015-03-07 21:41 ` [RFC 13/18] v4l: of: Read lane-polarity endpoint property Sakari Ailus
2015-03-07 23:49 ` Laurent Pinchart
2015-03-12 22:23 ` Sakari Ailus
[not found] ` <20150312222327.GM11954-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-03-12 22:25 ` Sakari Ailus
2015-03-07 21:41 ` [RFC 17/18] arm: dts: n950, n9: Add primary camera support Sakari Ailus
[not found] ` <1425764475-27691-18-git-send-email-sakari.ailus-X3B1VOXEql0@public.gmane.org>
2015-03-07 23:56 ` Laurent Pinchart
2015-03-08 0:03 ` Sakari Ailus
2015-03-07 21:41 ` [RFC 18/18] omap3isp: Deprecate platform data support Sakari Ailus
2015-03-07 23:35 ` Laurent Pinchart
[not found] ` <1425764475-27691-19-git-send-email-sakari.ailus-X3B1VOXEql0@public.gmane.org>
2015-03-13 9:40 ` Sebastian Reichel
2015-03-13 16:43 ` Tony Lindgren
2015-03-07 21:41 ` [RFC 11/18] omap3isp: Replace many MMIO regions by two Sakari Ailus
2015-03-07 23:43 ` Laurent Pinchart
2015-03-09 15:22 ` Tony Lindgren
2015-03-07 21:41 ` [RFC 12/18] dt: bindings: Add lane-polarity property to endpoint nodes Sakari Ailus
2015-03-07 23:46 ` Laurent Pinchart
2015-03-07 23:57 ` Sakari Ailus
2015-03-07 21:41 ` [RFC 14/18] dt: bindings: Add bindings for omap3isp Sakari Ailus
2015-03-11 23:39 ` Laurent Pinchart
2015-03-12 23:03 ` Sakari Ailus
2015-03-12 23:11 ` Laurent Pinchart
2015-03-12 23:43 ` Sakari Ailus
[not found] ` <20150312230320.GO11954-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2015-03-13 9:34 ` Sebastian Reichel
2015-03-14 0:33 ` Laurent Pinchart
2015-03-14 14:10 ` Sakari Ailus
2015-03-07 21:41 ` [RFC 15/18] omap3isp: Add support for the Device Tree Sakari Ailus
[not found] ` <1425764475-27691-16-git-send-email-sakari.ailus-X3B1VOXEql0@public.gmane.org>
2015-03-11 23:48 ` Laurent Pinchart
2015-03-14 14:12 ` Sakari Ailus
2015-03-07 21:41 ` [RFC 16/18] arm: dts: omap3: Add DT entries for OMAP 3 Sakari Ailus
[not found] ` <1425764475-27691-17-git-send-email-sakari.ailus-X3B1VOXEql0@public.gmane.org>
2015-03-07 23:51 ` Laurent Pinchart
2015-03-14 14:43 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2008156.hkDykbnpAV@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).