From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC 01/18] omap3isp: Fix error handling in probe Date: Sun, 08 Mar 2015 01:17:40 +0200 Message-ID: <2008156.hkDykbnpAV@avalon> References: <1425764475-27691-1-git-send-email-sakari.ailus@iki.fi> <1425764475-27691-2-git-send-email-sakari.ailus@iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1425764475-27691-2-git-send-email-sakari.ailus@iki.fi> Sender: linux-media-owner@vger.kernel.org To: Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, pali.rohar@gmail.com List-Id: devicetree@vger.kernel.org Hi Sakari, Thank you for the patch. On Saturday 07 March 2015 23:40:58 Sakari Ailus wrote: > The mutex was not destroyed correctly if dma_coerce_mask_and_coherent() > failed for some reason. > > Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart > --- > drivers/media/platform/omap3isp/isp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index deca809..fb193b6 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2252,7 +2252,7 @@ static int isp_probe(struct platform_device *pdev) > > ret = dma_coerce_mask_and_coherent(isp->dev, DMA_BIT_MASK(32)); > if (ret) > - return ret; > + goto error; > > platform_set_drvdata(pdev, isp); -- Regards, Laurent Pinchart