From: David Gibson <david@gibson.dropbear.id.au>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org
Subject: Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking
Date: Wed, 1 Apr 2009 10:06:26 +1100 [thread overview]
Message-ID: <20090331230626.GB23304@yookeroo.seuss> (raw)
In-Reply-To: <20090331124348.330571158@denx.de>
On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote:
> The I2c node property "fsl,preserve-clocking" allows to overtake the
> clock settings from the boot loader and avoids the hard-coded setting.
Hrm. This is dubious. The device tree should generally describe
hardware, not OS/driver behaviour which is what this appears to be
doing. There are exceptions, but you need to justify them.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2009-03-31 23:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 12:43 [PATCH 0/2] test Wolfgang Grandegger
2009-03-31 12:43 ` [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking Wolfgang Grandegger
2009-03-31 23:06 ` David Gibson [this message]
[not found] ` <20090331230626.GB23304-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2009-04-01 7:40 ` Wolfgang Grandegger
[not found] ` <49D31A5D.8030204-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-04-02 0:07 ` David Gibson
2009-03-31 12:43 ` [PATCH 2/2] powerpc: i2c-mpc: make I2C bus speed configurable Wolfgang Grandegger
-- strict thread matches above, loose matches on Subject: below --
2009-03-31 12:50 [PATCH 0/2] " Wolfgang Grandegger
2009-03-31 12:50 ` [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking Wolfgang Grandegger
[not found] ` <20090331125451.600446749-ynQEQJNshbs@public.gmane.org>
2009-03-31 13:39 ` Wolfram Sang
2009-03-31 13:47 ` Wolfgang Grandegger
[not found] ` <49D21EF1.9050200-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-03-31 13:56 ` Wolfram Sang
[not found] ` <20090331135629.GC3044-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-03-31 15:44 ` Grant Likely
[not found] ` <fa686aa40903310844j11a85fb6w3558923e12670ba9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-03-31 20:05 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331230626.GB23304@yookeroo.seuss \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-discuss@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox