From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Don't use echo -e in run_tests.sh Date: Thu, 12 Nov 2009 11:56:34 +1100 Message-ID: <20091112005634.GJ3235@yookeroo.seuss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jon Loeliger Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org In one section, the run_tests script attempts to use the -e (interpret escapes) option to echo. This option is not portable - for example the echo built into dash, now the default /bin/sh on several distributions does not support it and will just echo "-e" literally. Since we don't actually use any of the escapes that -e enables, this patch simply removes it. Signed-off-by: David Gibson Index: dtc/tests/run_tests.sh =================================================================== --- dtc.orig/tests/run_tests.sh 2009-11-12 11:52:41.000000000 +1100 +++ dtc/tests/run_tests.sh 2009-11-12 11:52:50.000000000 +1100 @@ -339,14 +339,14 @@ for set in $TESTSETS; do esac done -echo -e "********** TEST SUMMARY" -echo -e "* Total testcases: $tot_tests" -echo -e "* PASS: $tot_pass" -echo -e "* FAIL: $tot_fail" -echo -e "* Bad configuration: $tot_config" +echo "********** TEST SUMMARY" +echo "* Total testcases: $tot_tests" +echo "* PASS: $tot_pass" +echo "* FAIL: $tot_fail" +echo "* Bad configuration: $tot_config" if [ -n "$VALGRIND" ]; then - echo -e "* valgrind errors: $tot_vg" + echo "* valgrind errors: $tot_vg" fi -echo -e "* Strange test result: $tot_strange" -echo -e "**********" +echo "* Strange test result: $tot_strange" +echo "**********" -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson