From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F5DC3F6B0 for ; Fri, 19 Aug 2022 14:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349569AbiHSOfS (ORCPT ); Fri, 19 Aug 2022 10:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349526AbiHSOfR (ORCPT ); Fri, 19 Aug 2022 10:35:17 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30F08EC4CA for ; Fri, 19 Aug 2022 07:35:16 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id o2so6396801lfb.1 for ; Fri, 19 Aug 2022 07:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=SeHZ27XNszROnXvDUYzNdYyTiRb4BIM2jQzW5MqSyEc=; b=fbb2z35hagDVu/Vg+G7F5H05F7hWxuAt0ZwmlDzFzuM4i1aO4sFlU2Y00/zuyo7/5T 8FlxQNdqmf3CE1KeZC3pwOhWFEibAmKmjH+OF9IkzzlGmMVM2bLySkK0Jyjz+90FiV4R db6WpvpkhZxEFJb2lhcNXg10wOC1Yg6bv+kseazCF2v3BFGbeoJDa5GEL17uqf5zHoVV WJFEt1ZOzRgc/MAQDMj72DDJc5KYg9GUStNnZwVF2dAdnNX6Vg/8VDTK16kSO+l5kBl3 zSPhOzBx7G3NlCNRMTUmOOPxL++gXO14fdgr/yxsuQBLSTaOUrq/8Sr38zi8/kFOCdO3 jCoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=SeHZ27XNszROnXvDUYzNdYyTiRb4BIM2jQzW5MqSyEc=; b=X5ipHCeL432RjwcfkGiWBgfvAM1bHnTJXpu24656M1QusIzjx4+R6PVvsacZgMQpBz +KOU48tdj7+MfWCuPbXnsgl9USKVn2VPEv6Pb/BzAeNKjUC4/tdgX3n7XiIMHH6WUIHJ jS9VB4939eRL8iB5uRu0OTC4v1iOhXnQuVFecgZt3ZEDBDUXHIk+OzxrGyh03TZI9f78 Pv5DdYvjVBMplDpudGDmTVY+hWK/9TZhA/wl4wx7JUT0YDuO13T2/i+/rmx7z0tk795Y 1r7lWzGedIjU0r+jPk8NLCkluXo+GXV0Y1Zz8Flv4dZPhCclEvt4QPrUDUi5vI0EQyoM SK0Q== X-Gm-Message-State: ACgBeo0xjz/eKk8qnoW8C5q3oCQhViVJO1wPJcRj8dmssVqBju6PfZsR zUd+c6dJBI6KYXfJHaor05irRw== X-Google-Smtp-Source: AA6agR7Zi6Ib+jSmmdNrH2FE8pP3qnIypeXUxNqJmIpV/7jD9ZnC1uDf4dVnk9URUxLDS2lqc7BDHA== X-Received: by 2002:a05:6512:1193:b0:492:7e33:870 with SMTP id g19-20020a056512119300b004927e330870mr2642782lfr.37.1660919714599; Fri, 19 Aug 2022 07:35:14 -0700 (PDT) Received: from ?IPV6:2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5? (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id s25-20020a05651c049900b00261c241d4a1sm35245ljc.59.2022.08.19.07.35.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 07:35:14 -0700 (PDT) Message-ID: <200e3faf-e377-9fab-7cb2-bbea07be00cf@linaro.org> Date: Fri, 19 Aug 2022 17:35:12 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 6/6] riscv: dts: microchip: add the mpfs' fabric clock control Content-Language: en-US To: Conor.Dooley@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, Daire.McNamara@microchip.com Cc: paul.walmsley@sifive.com, aou@eecs.berkeley.edu, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220819122259.183600-1-conor.dooley@microchip.com> <20220819122259.183600-7-conor.dooley@microchip.com> <3df8d4bd-3d38-cecd-6589-ccc1be01b886@linaro.org> <3ffba600-bda9-8ffa-a435-9a6f94e072b8@microchip.com> <19ca2ca1-c678-c669-4214-e92416e37191@microchip.com> <138af26e-8e36-63a0-d3a0-5af866318839@linaro.org> <4e12e8c3-2170-eaab-d910-f674bcc93f79@linaro.org> <560e80df-4819-1062-50ee-eb1d1d19bae1@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <560e80df-4819-1062-50ee-eb1d1d19bae1@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/08/2022 17:32, Conor.Dooley@microchip.com wrote: >> The clock names should not really matter, so if you have conflict of >> names among multiple controllers, I think driver should embed unit >> address in the name (as fallback of clock-output-name) and the binding >> should not enforce specific pattern. > > Not sure if you just passed over it, but I agree: >>> Truncated base address I suppose would be a meaningful thing >>> to fall back to afterwards. Yeah, indeed, you mentioned it. > > But if the names aren't an ABI, then either there's not much point in > having the regex at all for clock-output-names or failing the check for > it does not matter. I'll have a think over the weekend about what > exactly to do, but I think the driver side of this is clear to me now & > what not to do in the binding is too. Yes. > >> I can easily imagine a real hardware board design with >> "sexy_duck_ccc_pll1_out3" clock names. :) > > If Alestorm made a board with our FPGA, I could see that.. > I'd buy the t-shirt too! > Best regards, Krzysztof