Devicetree
 help / color / mirror / Atom feed
From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] of: added documentation for spi chipselects
Date: Wed, 17 Feb 2010 13:22:33 +0100	[thread overview]
Message-ID: <20100217132233.19b25f4b.eschwab@online.de> (raw)
In-Reply-To: <20100216201459.GA17428-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:

> Minor: I'd prefer spaces around the '='.
Done.

> I'd drop the comments. GPIO controllers may have private xlate-functions, so
> '1' could theoretically mean something else than "low-active" (although in
> practice it hopefully won't).

I dropped the polarity stuff. The "reg =" comment seems important
to me, I had to find this out by grep'ing and looking at the 
SPI master sourcecode. 
Patch V2 will be reposted.

Regards
Ernst

  parent reply	other threads:[~2010-02-17 12:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 18:39 [PATCH] of: added documentation for spi chipselects Ernst Schwab
     [not found] ` <20100216193957.ccdffee2.eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
2010-02-16 19:00   ` Grant Likely
2010-02-16 20:14   ` Wolfram Sang
     [not found]     ` <20100216201459.GA17428-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-17 12:22       ` Ernst Schwab [this message]
2010-02-17 12:23       ` [PATCH V2] " Ernst Schwab
     [not found]         ` <20100217132322.76cea805.eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
2010-02-17 13:41           ` Wolfram Sang
     [not found]             ` <20100217134138.GC26125-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-02-17 14:15               ` [PATCH] of: added documentation for spi chipselects, follow-up patch Ernst Schwab
2010-02-17 14:33               ` [PATCH V2] of: added documentation for spi chipselects Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217132233.19b25f4b.eschwab@online.de \
    --to=eschwab-bgeptl67xyczqb+pc5nmwq@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox