From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: dtc: Allow multiple labels on nodes and properties (v2)
Date: Thu, 25 Feb 2010 08:58:44 +1100 [thread overview]
Message-ID: <20100224215844.GB31576@yookeroo> (raw)
In-Reply-To: <E1NkIfh-0005pc-R0-CYoMK+44s/E@public.gmane.org>
On Wed, Feb 24, 2010 at 08:57:05AM -0600, Jon Loeliger wrote:
> > Oops, don't apply that one, it has an uninitialized variable bug.
> > Here's a fixed version.
> >
> > dtc: Allow multiple labels on nodes and properties
> >
> > At present, both the grammar and our internal data structures mean
> > that there can be only one label on a node or property. This is a
> > fairly arbitrary constraint, given that any number of value labels can
> > appear at the same point, and that in C you can have any number of
> > labels on the same statement.
> >
> > This is pretty much a non-issue now, but it may become important with
> > some of the extensions that Grant and I have in mind. It's not that
> > hard to change, so this patch does so, allowing an arbitrary number of
> > labels on any given node or property. As usual a testcase is added
> > too.
> >
> > Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> >
> > Index: dtc/tests/multilabel.dts
> > ===================================================================
> > --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> > +++ dtc/tests/multilabel.dts 2010-02-24 17:57:12.736958851 +1100
> > @@ -0,0 +1,38 @@
>
>
> So, I applied this. But I had to make an extra amend step to
> fix three things after applying it:
>
> - Remove the meta-comment, (placed after triple dash line)
> - Remove the extraneous "(v2)", (placed in Subject brackets)
> - Remove the duplicate Subject: line, (not repeated in body)
Good point, sorry. I'll keep that in mind in future.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2010-02-24 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 1:03 dtc: Allow multiple labels on nodes and properties David Gibson
2010-02-24 2:10 ` Grant Likely
2010-02-24 7:22 ` dtc: Allow multiple labels on nodes and properties (v2) David Gibson
2010-02-24 14:57 ` Jon Loeliger
[not found] ` <E1NkIfh-0005pc-R0-CYoMK+44s/E@public.gmane.org>
2010-02-24 21:58 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224215844.GB31576@yookeroo \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox