From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch] of: check for IS_ERR() Date: Fri, 26 Feb 2010 01:54:20 -0800 (PST) Message-ID: <20100226.015420.66646406.davem@davemloft.net> References: <20100226094941.GE4912@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100226094941.GE4912@bicker> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: jezz-kPcTzGkeZgAdnm+yROfE0A@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, afleming-KZfg59tc24xl57MIdRCFDg@public.gmane.org, jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org List-Id: devicetree@vger.kernel.org From: Dan Carpenter Date: Fri, 26 Feb 2010 12:49:41 +0300 > get_phy_device() can return an ERR_PTR() > > Signed-off-by: Dan Carpenter > --- > I don't have a cross compile environment set up so I can't even compile > test this. :/ But err.h is included so it should be OK. It should return ERR_PTR() consistently. Checking for both NULL and ERR_PTR() is undesirable.