Devicetree
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: devicetree-discuss@lists.ozlabs.org
Cc: sparclinux@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, cjb@laptop.org,
	Mitch Bradley <wmb@laptop.org>,
	pgf@laptop.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net, grant.likely@secretlab.ca
Subject: [PATCH 1/4] x86: OLPC: constify an olpc_ofw() arg
Date: Mon, 28 Jun 2010 22:00:29 -0400	[thread overview]
Message-ID: <20100628220029.1555ac24@debian> (raw)
In-Reply-To: <20100628215407.2017bf2f@debian>


The arguments passed to OFW shouldn't be modified; update the 'args'
argument of olpc_ofw to reflect this.  This saves us some later
casting away of consts.

Signed-off-by: Andres Salomon <dilinger@queued.net>
---
 arch/x86/include/asm/olpc_ofw.h |    2 +-
 arch/x86/kernel/olpc.c          |    2 +-
 arch/x86/kernel/olpc_ofw.c      |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/olpc_ofw.h b/arch/x86/include/asm/olpc_ofw.h
index 3e63d85..08fde47 100644
--- a/arch/x86/include/asm/olpc_ofw.h
+++ b/arch/x86/include/asm/olpc_ofw.h
@@ -12,7 +12,7 @@
 #define olpc_ofw(name, args, res) \
 	__olpc_ofw((name), ARRAY_SIZE(args), args, ARRAY_SIZE(res), res)
 
-extern int __olpc_ofw(const char *name, int nr_args, void **args, int nr_res,
+extern int __olpc_ofw(const char *name, int nr_args, const void **args, int nr_res,
 		void **res);
 
 /* determine whether OFW is available and lives in the proper memory */
diff --git a/arch/x86/kernel/olpc.c b/arch/x86/kernel/olpc.c
index f5ff390..0e0cdde 100644
--- a/arch/x86/kernel/olpc.c
+++ b/arch/x86/kernel/olpc.c
@@ -188,7 +188,7 @@ static void __init platform_detect(void)
 {
 	size_t propsize;
 	__be32 rev;
-	void *args[] = { NULL, "board-revision-int", &rev, (void *)4 };
+	const void *args[] = { NULL, "board-revision-int", &rev, (void *)4 };
 	void *res[] = { &propsize };
 
 	if (olpc_ofw("getprop", args, res) || propsize != 4) {
diff --git a/arch/x86/kernel/olpc_ofw.c b/arch/x86/kernel/olpc_ofw.c
index deac703..3e13a4b 100644
--- a/arch/x86/kernel/olpc_ofw.c
+++ b/arch/x86/kernel/olpc_ofw.c
@@ -39,7 +39,7 @@ void __init setup_olpc_ofw_pgd(void)
 	/* implicit optimization barrier here due to uninline function return */
 }
 
-int __olpc_ofw(const char *name, int nr_args, void **args, int nr_res,
+int __olpc_ofw(const char *name, int nr_args, const void **args, int nr_res,
 		void **res)
 {
 	int ofw_args[MAXARGS + 3];
-- 
1.5.6.5


  reply	other threads:[~2010-06-29  2:00 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29  1:54 [PATCH 0/4] RFC: OLPC/x86 device tree code Andres Salomon
2010-06-29  2:00 ` Andres Salomon [this message]
2010-06-29  2:00 ` [PATCH 2/4] sparc: break out some prom device-tree building code out into drivers/of Andres Salomon
2010-06-29  3:11   ` David Miller
2010-06-29  6:15   ` Stephen Rothwell
2010-06-29  7:50   ` Grant Likely
2010-06-29 15:03     ` Andres Salomon
2010-06-29 21:42       ` Grant Likely
2010-06-29 23:36         ` Andres Salomon
2010-06-30 21:52           ` Grant Likely
     [not found]             ` <AANLkTilme2uAoXjorUEzam9j_xosR8kl70W8PS71d-Th-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-06  2:17               ` Andres Salomon
2010-07-06  2:22                 ` David Miller
     [not found]                   ` <20100705.192221.241453945.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-07-06  3:24                     ` Andres Salomon
2010-07-06 10:17                       ` Benjamin Herrenschmidt
2010-07-06  3:25                   ` Andres Salomon
2010-07-06  3:25                   ` Andres Salomon
2010-07-06  7:00                   ` Grant Likely
2010-07-06  7:16                     ` David Miller
2010-07-06  8:17                       ` Grant Likely
2010-07-06  8:17                 ` Grant Likely
2010-07-06  2:17             ` Andres Salomon
2010-07-06  2:17             ` Andres Salomon
2010-07-06  9:21   ` Grant Likely
2010-07-06 21:54     ` Andres Salomon
2010-07-06 22:06       ` Grant Likely
2010-07-07  1:15         ` Andres Salomon
2010-06-29  2:00 ` [PATCH 3/4] proc: unify PROC_DEVICETREE config Andres Salomon
2010-06-29  7:33   ` Grant Likely
2010-06-29  2:00 ` [PATCH 4/4] x86: OLPC: add OLPC device-tree support Andres Salomon
2010-06-29  8:12   ` Grant Likely
     [not found]     ` <AANLkTinUy_FGuN9DiF5KtMCsqYUbByfS6g2Mdw0ATvtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-29  8:33       ` Stephen Rothwell
2010-06-29 14:23       ` Andres Salomon
     [not found]         ` <20100629102339.5e8a30b6-ztAUm9HJea/EueBKFXcDjA@public.gmane.org>
2010-06-30 21:13           ` Grant Likely
     [not found]             ` <AANLkTik7rqaGz7RtsOlhoSZw_-6bhv43YlWETsB17__4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-30 21:32               ` Andres Salomon
2010-08-30  3:51 ` [PATCH 0/9] " Andres Salomon
2010-08-30  3:53   ` [PATCH 1/9] of: move phandle/ihandle into types.h Andres Salomon
2010-08-30  5:06     ` Sam Ravnborg
2010-09-03  8:17       ` Andres Salomon
2010-09-05  6:22         ` Sam Ravnborg
2010-08-30  3:55   ` [PATCH 2/9] sparc: convert various prom_* functions to use phandle Andres Salomon
2010-08-30  3:57   ` [PATCH 3/9] sparc: break out some PROM device-tree building code out into drivers/of Andres Salomon
2010-08-30  3:59   ` [PATCH 4/9] sparc: make drivers/of/pdt.c no longer sparc-only Andres Salomon
2010-08-30  4:00   ` [PATCH 5/9] of: no longer call prom_ functions directly; use an ops structure Andres Salomon
2010-08-30  4:02   ` [PATCH 6/9] of: add of_pdt namespace to pdt code Andres Salomon
2010-08-30  4:04   ` [PATCH 7/9] of: add package-to-path support to pdt Andres Salomon
2010-08-30  4:06   ` [PATCH 8/9] x86: of: irq additions to make drivers/of/* build on x86 Andres Salomon
2010-08-30 15:58     ` Stephen Neuendorffer
     [not found]       ` <c7823e09-3ce8-434f-98f4-6a84a996c942-RaUQJvECHitZbvUCbuG1mrjjLBE8jN/0@public.gmane.org>
2010-08-30 17:31         ` Grant Likely
2010-08-30  4:07   ` [PATCH 9/9] x86: OLPC: add OLPC device-tree support Andres Salomon
2010-08-30 18:14     ` Grant Likely
     [not found]       ` <AANLkTi=EMkZLiAG7-ni8_7K=qtAriv=AfSUZ58661jNY-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-30 18:49         ` Andres Salomon
2010-08-31  5:49           ` Grant Likely
2010-08-30 17:58   ` [PATCH 0/9] " Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100628220029.1555ac24@debian \
    --to=dilinger@queued.net \
    --cc=cjb@laptop.org \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pgf@laptop.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wmb@laptop.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox