From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org
Cc: sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org,
microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org
Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()
Date: Mon, 26 Jul 2010 15:48:54 -0700 (PDT) [thread overview]
Message-ID: <20100726.154854.35052662.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTikcV3jJUm_My-oK-drudSDz3M2iH1cWhxdt+W1s-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Date: Mon, 26 Jul 2010 16:42:20 -0600
> It protects against some later include file doing a #define
> of_node_to_nid and thus resulting in an inconsistent definition. If
> some code tries to do this then the preprocessor will complain. This
> is the pattern that Stephen suggested.
Also, it would be nice to unravel the "0" vs. "-1" default
inconsistency.
next prev parent reply other threads:[~2010-07-26 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 22:04 [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Grant Likely
2010-07-26 22:05 ` Grant Likely
2010-07-26 22:26 ` Sam Ravnborg
2010-07-26 22:42 ` Grant Likely
[not found] ` <AANLkTikcV3jJUm_My-oK-drudSDz3M2iH1cWhxdt+W1s-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-26 22:48 ` David Miller [this message]
2010-07-26 22:51 ` Grant Likely
[not found] ` <AANLkTikpON7WUkTLrnW4y2kghM=H8cLCAFst08S3cL_Z-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-27 1:38 ` David Miller
[not found] ` <20100726.183808.15223674.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-07-27 1:57 ` Grant Likely
2010-07-27 13:34 ` Arnd Bergmann
2010-07-27 16:52 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726.154854.35052662.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org \
--cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox