From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Date: Tue, 27 Jul 2010 18:52:50 +0200 Message-ID: <20100727165250.GB26649@merkur.ravnborg.org> References: <20100726220405.1550.63442.stgit@angua> <20100726222627.GA23501@merkur.ravnborg.org> <201007271534.01250.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201007271534.01250.arnd@arndb.de> Sender: sparclinux-owner@vger.kernel.org To: Arnd Bergmann Cc: devicetree-discuss@lists.ozlabs.org, Grant Likely , sfr@canb.auug.org.au, microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, davem@davemloft.net List-Id: devicetree@vger.kernel.org On Tue, Jul 27, 2010 at 03:34:01PM +0200, Arnd Bergmann wrote: > On Tuesday 27 July 2010, Grant Likely wrote: > > > I suggest to go back to v2 of your patch where you use asm-generic/of.h. > > > > Stephen suggested dropping asm-generic/of.h. I'm happy to do it either way. > > I don't mind adding stuff to asm-generic, but I think in this case it would > be easier to keep this in linux/of.h because there is nothing wrong with > all architectures including it. > > Most files in asm-generic are there only for historical reasons, where some > architectures use them but others don't. IMHO we should use the include/linux > headers preferred for new stuff though. Hi Arnd. Thanks for this explanation. Obviously my previous post about asm-generic was wrong (as Grant already indicated). Sam