Re: [PATCH] drivers/of: use __be32 types for big-endian device tree data

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Tue, Sep 14, 2010 at 11:13:51AM +0800, Jeremy Kerr wrote:
> Use the sparse annotations so we can keep track of endianness.
> 
> Signed-off-by: Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>

Added to my test-devicetree branch

g.

> 
> ---
>  drivers/of/address.c |    2 +-
>  drivers/of/base.c    |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index fcadb72..3a1c7e7 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -163,7 +163,7 @@ static int of_bus_pci_translate(u32 *addr, u64 offset, int na)
>  const u32 *of_get_pci_address(struct device_node *dev, int bar_no, u64 *size,
>  			unsigned int *flags)
>  {
> -	const u32 *prop;
> +	const __be32 *prop;
>  	unsigned int psize;
>  	struct device_node *parent;
>  	struct of_bus *bus;
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index aa80525..710b53b 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -33,7 +33,7 @@ DEFINE_RWLOCK(devtree_lock);
>  
>  int of_n_addr_cells(struct device_node *np)
>  {
> -	const int *ip;
> +	const __be32 *ip;
>  
>  	do {
>  		if (np->parent)
> @@ -49,7 +49,7 @@ EXPORT_SYMBOL(of_n_addr_cells);
>  
>  int of_n_size_cells(struct device_node *np)
>  {
> -	const int *ip;
> +	const __be32 *ip;
>  
>  	do {
>  		if (np->parent)