From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: John Bonesio <bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] Change yyerror to use stdarg so we can give more descriptive errors.
Date: Sat, 16 Oct 2010 17:38:06 +1100 [thread overview]
Message-ID: <20101016063806.GC5036@yookeroo> (raw)
In-Reply-To: <20101016003239.3900.85967.stgit@riker>
On Fri, Oct 15, 2010 at 05:33:04PM -0700, John Bonesio wrote:
> The subject pretty much says it all. The patch is to allow dtc to
> give more descriptive errors by having yyerror take a variable
> number of parameters printf style.
Sorry, nack. yyerror() is provided for bison's convenience and is
defined by that interface to be void yyerror(const char *s). We just
use it explicitly because it happens to be there.
Yes, I know it's unlikely that bison would supply a string with format
specifiers which would mess things up but I'm still not comfortable
changing the signature when there's no need. If you want a varargs
error printing function, define and use one (well, if srcpos_error()
isn't close enough) instead of yyerror().
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2010-10-16 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 0:33 [PATCH] Change yyerror to use stdarg so we can give more descriptive errors John Bonesio
2010-10-16 1:09 ` Grant Likely
2010-10-16 6:38 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101016063806.GC5036@yookeroo \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox