Devicetree
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Michal Simek <monstr@monstr.eu>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [PATCH] ll_temac: Fix section mismatch from the temac_of_probe
Date: Mon, 3 Jan 2011 10:03:32 -0700	[thread overview]
Message-ID: <20110103170332.GB2522@angua.secretlab.ca> (raw)
In-Reply-To: <1294050756-31099-1-git-send-email-monstr@monstr.eu>

On Mon, Jan 03, 2011 at 11:32:36AM +0100, Michal Simek wrote:
> Replace __init by __devinit.
> 
> Warning message:
> WARNING: vmlinux.o(.data+0xbc14): Section mismatch in reference from the variable
> temac_of_driver to the function .init.text:temac_of_probe()
> The variable temac_of_driver references
> the function __init temac_of_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
> 
> Signed-off-by: Michal Simek <monstr@monstr.eu>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

> ---
>  drivers/net/ll_temac_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ll_temac_main.c b/drivers/net/ll_temac_main.c
> index 9f8e702..beb6ed8 100644
> --- a/drivers/net/ll_temac_main.c
> +++ b/drivers/net/ll_temac_main.c
> @@ -952,7 +952,7 @@ static const struct attribute_group temac_attr_group = {
>  	.attrs = temac_device_attrs,
>  };
>  
> -static int __init
> +static int __devinit
>  temac_of_probe(struct platform_device *op, const struct of_device_id *match)
>  {
>  	struct device_node *np;
> -- 
> 1.5.5.6
> 

  reply	other threads:[~2011-01-03 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 10:32 [PATCH] ll_temac: Fix section mismatch from the temac_of_probe Michal Simek
2011-01-03 17:03 ` Grant Likely [this message]
2011-01-03 20:07   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110103170332.GB2522@angua.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox