From: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
To: Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Vincent Sanders <vince-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 4/4 v5] powerpc, video: add SM501 support for charon board.
Date: Tue, 25 Jan 2011 15:49:49 +0900 [thread overview]
Message-ID: <20110125064949.GF11673@linux-sh.org> (raw)
In-Reply-To: <1295937946-26934-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
On Tue, Jan 25, 2011 at 07:45:46AM +0100, Heiko Schocher wrote:
> @@ -197,6 +198,15 @@
> #address-cells = <1>;
> };
>
> + display@1,0 {
> + compatible = "smi,sm501";
> + reg = <1 0x00000000 0x00800000
> + 1 0x03e00000 0x00200000>;
> + mode = "640x480-32@60";
> + interrupts = <1 1 3>;
> + little-endian;
> + };
> +
The endian designation looks good, but it still doesn't explain why you
have a remaining CONFIG_PPC_MPC52xx ifdef encapsulating the property
check in the sm501fb patch. It shouldn't be needed at all. If the
platform supports OF then the property will need to be set one way or the
other, so there is no need for any board or CPU ifdeffery within the
driver itself.
next prev parent reply other threads:[~2011-01-25 6:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291451028-22532-2-git-send-email-hs@denx.de>
[not found] ` <1291451028-22532-2-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2010-12-07 6:59 ` [PATCH 2/2 v2] powerpc, video: add SM501 support for charon board Heiko Schocher
2010-12-11 6:31 ` [PATCH v3 2/2] " Heiko Schocher
2011-01-24 9:57 ` [PATCH 4/4 v4] " Heiko Schocher
2011-01-25 6:45 ` [PATCH 4/4 v5] " Heiko Schocher
[not found] ` <1295937946-26934-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2011-01-25 6:49 ` Paul Mundt [this message]
[not found] ` <20110125064949.GF11673-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2011-01-25 7:07 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125064949.GF11673@linux-sh.org \
--to=lethal-m7jkjyw5wf5g9huczpvpmw@public.gmane.org \
--cc=ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=hs-ynQEQJNshbs@public.gmane.org \
--cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=vince-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).