From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH 4/4 v5] powerpc, video: add SM501 support for charon board. Date: Tue, 25 Jan 2011 15:49:49 +0900 Message-ID: <20110125064949.GF11673@linux-sh.org> References: <1291451028-22532-2-git-send-email-hs@denx.de> <1295937946-26934-1-git-send-email-hs@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1295937946-26934-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Heiko Schocher Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Samuel Ortiz , Vincent Sanders , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Jan 25, 2011 at 07:45:46AM +0100, Heiko Schocher wrote: > @@ -197,6 +198,15 @@ > #address-cells = <1>; > }; > > + display@1,0 { > + compatible = "smi,sm501"; > + reg = <1 0x00000000 0x00800000 > + 1 0x03e00000 0x00200000>; > + mode = "640x480-32@60"; > + interrupts = <1 1 3>; > + little-endian; > + }; > + The endian designation looks good, but it still doesn't explain why you have a remaining CONFIG_PPC_MPC52xx ifdef encapsulating the property check in the sm501fb patch. It shouldn't be needed at all. If the platform supports OF then the property will need to be set one way or the other, so there is no need for any board or CPU ifdeffery within the driver itself.