From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/3] of: define dummy of_get_property if not CONFIG_OF Date: Mon, 31 Jan 2011 15:10:47 -0700 Message-ID: <20110131221047.GA27856@angua.secretlab.ca> References: <1296487551-30938-1-git-send-email-thomas@wytron.com.tw> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1296487551-30938-1-git-send-email-thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Thomas Chou Cc: nios2-dev-1eJk0qcHJCcaeqlQEoCUNoJY59XmG8rH@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Jean Delvare , Haavard Skinnemoen List-Id: devicetree@vger.kernel.org On Mon, Jan 31, 2011 at 11:25:49PM +0800, Thomas Chou wrote: > This will help to reduce the ifdef CONFIG_OF needed in most > platform data probing. > > Signed-off-by: Thomas Chou With moving the dt reading into a separate function protected by CONFIG_OF, this patch shouldn't be necessary. g. > --- > include/linux/of.h | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/include/linux/of.h b/include/linux/of.h > index cad7cf0..5e122cb 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -222,5 +222,13 @@ extern void of_attach_node(struct device_node *); > extern void of_detach_node(struct device_node *); > #endif > > +#else /* !CONFIG_OF */ > + > +static inline const void *of_get_property(const struct device_node *node, > + const char *name, int *lenp) > +{ > + return NULL; > +} > + > #endif /* CONFIG_OF */ > #endif /* _LINUX_OF_H */ > -- > 1.7.3.5 >