From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] i2c-gpio: add devicetree support Date: Mon, 31 Jan 2011 16:01:00 -0700 Message-ID: <20110131230100.GE27856@angua.secretlab.ca> References: <1296403013-6058-1-git-send-email-thomas@wytron.com.tw> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?iso-8859-1?Q?H=E5vard?= Skinnemoen Cc: Thomas Chou , Ben Dooks , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nios2-dev-1eJk0qcHJCcaeqlQEoCUNoJY59XmG8rH@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jean Delvare , Albert Herranz List-Id: devicetree@vger.kernel.org On Mon, Jan 31, 2011 at 02:35:31PM -0800, H=E5vard Skinnemoen wrote: > Hi, >=20 > On Mon, Jan 31, 2011 at 12:09 AM, Grant Likely > wrote: > > On Sun, Jan 30, 2011 at 8:26 PM, H=E5vard Skinnemoen > > wrote: > >> Hi, > >> > >> On Sun, Jan 30, 2011 at 7:56 AM, Thomas Chou wrote: > >>> From: Albert Herranz > >>> > >>> This patch is based on an earlier patch from Albert Herranz, > >>> http://git.infradead.org/users/herraa1/gc-linux-2.6.git/commit/ > >>> 9854eb78607c641ab5ae85bcbe3c9d14ac113733 > >> > >> That commit has a single-line description of which I don't underst= and > >> a single word (unless "wii" is what I think it is, which seems > >> likely). Could you please explain how that commit relates to this > >> patch? > > > > The URL got wrapped. =A0Try this one (assuming my mailer doesn't wr= ap it): > > > > http://git.infradead.org/users/herraa1/gc-linux-2.6.git/commit/9854= eb78607c641ab5ae85bcbe3c9d14ac113733 >=20 > Ok, that seems to be a _bit_ more related, but not that much. I'd > really prefer a patch description which can stand on its own. >=20 [...] > > >> Not saying that it necessarily _is_ a terrible idea, but I think t= he > >> reasoning behind it needs to be included in the patch description. > > > > Nah, he doesn't really need to defend this since it is a well > > established pattern. =A0device tree support is in core code now (se= e > > of_node an of_match_table in include/linux/device.h), and other > > drivers do exactly this. >=20 > Well, perhaps you're right, but I still think the patch description i= s > a bit on the thin side. In particular, terms like "as Grant suggested= " > isn't very helpful for people like me who don't know what you > suggested (even though I'm sure it was a good suggestion). >=20 > I think the patch lacks a good description of what's being changed an= d > why. The references may be nice to have as a supplement to that, but > describing things entirely in terms of some unknown e-mail discussion > that happened earlier is not very helpful for people who want to > figure out what's going on a couple of months or years from now. No arguments from me on those points. g.