From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v4] hwmon: Add support for Texas Instruments ADS1015 Date: Thu, 3 Mar 2011 21:02:36 +0100 Message-ID: <20110303200236.GA17132@pengutronix.de> References: <1299138343-12773-1-git-send-email-eibach@gdsys.de> <20110303175050.GC22940@angua.secretlab.ca> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6111917929097123674==" Return-path: In-Reply-To: <20110303175050.GC22940-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: Dirk Eibach , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Greg Kroah-Hartman , Kay Sievers List-Id: devicetree@vger.kernel.org --===============6111917929097123674== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > --- > > Changes since v1: > > - fixed/extended Documentation > > - removed unused register definitions > > - hardcoded PGA fullscale table size > > - made sure patch applies against v2.6.38-rc4 > > - reordered functions to avoid forward declaration > > - results from i2c_smbus_read_word_data() are handled correctly > > - moved locking into ads1015_read_value() > > - removed unnecessray clearing of bit > > - proper error handling in ads1015_read_value() > > - use DIV_ROUND_CLOSEST for scaling result > > - removed detect() > >=20 > > Changes since v2: > > - removed *all* leftovers from detect() > > - fixed return with mutex held > > - made sysfs representation configurable > > (hope this will be the reference implementation for generations to co= me ;) > >=20 > > Changes since v3: > > - included linux/of.h > > - remove linux/types.h from header file > > - sysfs is now configured with a bitmask > > - assume big-endian of-properties >=20 > I recommend putting the revision history *above* the '---' trim line. > It turns out to be useful to have the revision history in the commit > text that actually gets merged into mainline. Is this common sense meanwhile? (That is quite many additional lines per commit) Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAk1v89wACgkQD27XaX1/VRs6WgCgsawA+9QpY35Pmp4nZybtNZY+ o+sAoMSxahwlRnOckFa1VbJrqfOHsy+s =f3UC -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J-- --===============6111917929097123674== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============6111917929097123674==--