From: Andres Salomon <dilinger-pFFUokh25LWsTnJN9+BGXg@public.gmane.org>
To: Daniel Drake <dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [RFC 1/3] OLPC: Use device tree for platform identification
Date: Tue, 8 Mar 2011 19:35:46 -0800 [thread overview]
Message-ID: <20110308193546.151521a9@queued.net> (raw)
In-Reply-To: <AANLkTi=Jcq5SDbWgN+1TQNeP3CvJVRY7CO3c__DDEPz3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, 8 Mar 2011 21:13:00 +0000
Daniel Drake <dsd@laptop.org> wrote:
> On 4 March 2011 18:01, Andres Salomon <dilinger@queued.net> wrote:
> >> +static int __init declare_of_platform_devices(void)
> >> +{
> >> + return of_platform_bus_probe(NULL, of_ids, NULL);
> >> +}
> >> +device_initcall(declare_of_platform_devices);
> >
> > How about 'olpc_create_platform_devices' or some such name? That's
> > what's really happening here, right?
>
> The reason I called it declare_of_platform_devices is because thats
> what all the other platforms do (do a git grep). do you still think it
> should be renamed?
>
Yes, unless there's some reason why it should be named "declare". I'm
assuming the names used in ppc platform device code are like that for
historical reasons?
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2011-03-09 3:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 17:12 [RFC 1/3] OLPC: Use device tree for platform identification Daniel Drake
[not found] ` <20110304171214.2B5C69D401D-k/4jFdqg8LLlyo9zxV8I99HuzzzSOjJt@public.gmane.org>
2011-03-04 18:01 ` Andres Salomon
2011-03-08 21:13 ` Daniel Drake
[not found] ` <AANLkTi=Jcq5SDbWgN+1TQNeP3CvJVRY7CO3c__DDEPz3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-09 3:35 ` Andres Salomon [this message]
[not found] ` <20110308193546.151521a9-pFFUokh25LWsTnJN9+BGXg@public.gmane.org>
2011-03-12 7:45 ` Grant Likely
2011-03-05 4:28 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308193546.151521a9@queued.net \
--to=dilinger-pffuokh25lwstnjn9+bgxg@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).