From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Jason Hui <jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH V2 1/3] arm/dt: add basic mx51 device tree support
Date: Fri, 11 Mar 2011 13:10:43 +0100 [thread overview]
Message-ID: <201103111310.43339.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTi=3cXtnZA+8JW5+-OjjpJBC4SL26NoAMpnrgWmy-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Friday 11 March 2011, Jason Hui wrote:
> >> Alternatively, it could be done the other way round: rename the identifiers
> >> in the file from mx51_ to mx5_, and make sure that they don't contain
> >> any mx51 specific settings but always refer to properties in the
> >> device tree for the differences.
> >
> > I saw that your V4 still implements neither Shawn's suggestion nor mine.
>
> As you said, I don't want to make thing complex too. I don't want to
> have mx51_dt or
> mx53_dt as Shawn Suggests and I still don't want to make it change to
> mx5 now as you suggest
> Since this patch only support mx51 currently. I think it's easy to
> make change later once mx53 in-deed
> added in DT support, what do you think?
It would also be easy to rename the file from mx51_dt to board_dt
when it becomes more generic. I don't consider it a show-stopper
though and am comfortable with leaving it to your own judgement.
Generally speaking, you don't have to do everything that reviewers
suggest, but please reply to explain your reasons if you disagree.
Arnd
next prev parent reply other threads:[~2011-03-11 12:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 13:05 [PATCH V2 0/3] Add MX51 basic DT support Jason Liu
[not found] ` <1299503160-9910-1-git-send-email-jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-07 13:05 ` [PATCH V2 1/3] arm/dt: add basic mx51 device tree support Jason Liu
[not found] ` <1299503160-9910-2-git-send-email-jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-07 14:17 ` Shawn Guo
[not found] ` <20110307141656.GC7189-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-03-07 14:37 ` Arnd Bergmann
[not found] ` <201103071537.49026.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-07 14:46 ` Shawn Guo
[not found] ` <20110307144621.GB9978-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-03-07 14:52 ` Arnd Bergmann
[not found] ` <201103071552.26766.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-07 16:26 ` Grant Likely
2011-03-10 12:38 ` Arnd Bergmann
[not found] ` <201103101338.45187.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-11 3:18 ` Jason Hui
[not found] ` <AANLkTi=3cXtnZA+8JW5+-OjjpJBC4SL26NoAMpnrgWmy-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-11 12:10 ` Arnd Bergmann [this message]
[not found] ` <201103111310.43339.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-14 5:33 ` Jason Hui
2011-03-07 14:23 ` Shawn Guo
2011-03-07 13:05 ` [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board Jason Liu
[not found] ` <1299503160-9910-3-git-send-email-jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-07 13:44 ` Shawn Guo
2011-03-07 14:51 ` Shawn Guo
[not found] ` <20110307145136.GC9978-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-03-08 2:20 ` Jason Hui
[not found] ` <AANLkTi=NO+=wa8m980Q_uEMQDOXOUwy7h8Fzi4KZJ+a0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-08 3:11 ` Shawn Guo
[not found] ` <20110308031153.GA14370-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-03-08 3:31 ` Jason Hui
[not found] ` <AANLkTimSxsdWSvtWS00BbXOjvHS5g6CeYo+kH=K4VP7m-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-08 3:46 ` Shawn Guo
[not found] ` <20110308034646.GC14370-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-03-15 6:55 ` Grant Likely
2011-03-07 13:06 ` [PATCH V2 3/3] serial/imx: parse from device tree support Jason Liu
[not found] ` <1299503160-9910-4-git-send-email-jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-07 16:22 ` Grant Likely
[not found] ` <AANLkTinUajFtoOvChSQ_S2w9ZNcJCNf1d-7T7p2Dq3-B-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-08 2:56 ` Jason Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103111310.43339.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jason.hui-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).