devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org
Subject: Re: [PATCH 3/7] mmc: make the reference to sdhci_tegra_dt_pdata conditional
Date: Tue, 15 Mar 2011 01:58:59 -0600	[thread overview]
Message-ID: <20110315075859.GL23050@angua.secretlab.ca> (raw)
In-Reply-To: <1300112759-3495-4-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

On Mon, Mar 14, 2011 at 10:25:55PM +0800, Shawn Guo wrote:
> Wrap tegra dt_id with CONFIG_MMC_SDHCI_TEGRA to make the reference to
> sdhci_tegra_dt_pdata conditional, otherwise it will stop build for
> other mmc driver when OF is enabled.
> 
> Signed-off-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Looks right to me.

g.

> ---
>  drivers/mmc/host/sdhci-pltfm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index ccc04ac..4125fbf 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -52,7 +52,9 @@ static struct sdhci_ops sdhci_pltfm_ops = {
>  #if defined(CONFIG_OF)
>  #include <linux/of_device.h>
>  static const struct of_device_id sdhci_dt_ids[] = {
> +#ifdef CONFIG_MMC_SDHCI_TEGRA
>  	{ .compatible = "nvidia,tegra250-sdhci", .data = &sdhci_tegra_dt_pdata },
> +#endif
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(platform, sdhci_dt_ids);
> -- 
> 1.7.1
> 

  parent reply	other threads:[~2011-03-15  7:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14 14:25 [PATCH 0/7] support sdhci-esdhc-imx as an OF device Shawn Guo
     [not found] ` <1300112759-3495-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-14 14:25   ` [PATCH 1/7] mx51 enchance the sd/mmc HW timing compatibility on mx51 boards Shawn Guo
2011-03-14 14:25   ` [PATCH 2/7] arm/dt: add pad configurations for mx51 babbage Shawn Guo
     [not found]     ` <1300112759-3495-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-14 15:20       ` Rob Herring
     [not found]         ` <4D7E3230.6040505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-03-14 15:53           ` Shawn Guo
     [not found]             ` <20110314155313.GC3674-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-03-15  0:57               ` Shawn Guo
2011-03-15  7:57           ` Grant Likely
2011-03-14 14:25   ` [PATCH 3/7] mmc: make the reference to sdhci_tegra_dt_pdata conditional Shawn Guo
     [not found]     ` <1300112759-3495-4-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-15  7:58       ` Grant Likely [this message]
     [not found]         ` <20110315075859.GL23050-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2011-03-17 19:59           ` Grant Likely
     [not found]             ` <AANLkTi=umf9nDpExLEBgJEMgUP-CJUUEbAQrQfdBw7Fd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-18  1:22               ` Shawn Guo
     [not found]                 ` <20110318012202.GA26951-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-03-18  4:58                   ` Grant Likely
2011-03-14 14:25   ` [PATCH 4/7] mmc: consolidate sdhci_pltfm_data and sdhci_of_data into one Shawn Guo
     [not found]     ` <1300112759-3495-5-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-15 19:55       ` Grant Likely
     [not found]         ` <20110315195513.GA20845-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2011-03-17  6:33           ` Shawn Guo
2011-03-17 20:29             ` Grant Likely
2011-03-14 14:25   ` [PATCH 5/7] mmc: support sdhci-esdhc-imx as an OF device Shawn Guo
     [not found]     ` <1300112759-3495-6-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-03-15 19:59       ` Grant Likely
     [not found]         ` <20110315195926.GB20845-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2011-03-16 14:39           ` Shawn Guo
2011-03-17 20:22             ` Grant Likely
2011-03-17 20:42               ` Rob Herring
2011-03-14 14:25   ` [PATCH 6/7] arm/dts: babbage: add device nodes for esdhc Shawn Guo
2011-03-14 14:25   ` [PATCH 7/7] dt: update fsl-esdhc bindings for imx esdhc OF support Shawn Guo
2011-03-14 15:46   ` [PATCH 0/7] support sdhci-esdhc-imx as an OF device Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110315075859.GL23050@angua.secretlab.ca \
    --to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).