From: Wolfram Sang <w.sang@pengutronix.de>
To: Michal Simek <monstr@monstr.eu>
Cc: devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca,
john.williams@petalogix.com, linux-kernel@vger.kernel.org,
hjk@hansjkoch.de, arnd@arndb.de
Subject: Re: [PATCH v2] uio/pdrv_genirq: Add OF support
Date: Mon, 18 Apr 2011 17:25:51 +0200 [thread overview]
Message-ID: <20110418152551.GB23814@pengutronix.de> (raw)
In-Reply-To: <4DABF744.4010209@monstr.eu>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
> >>+
> >>+ /* Multiple IRQs are not supported */
> >>+ if (pdev->num_resources > 1) {
> >>+ struct resource *r = &pdev->resource[1];
> >
> >Are you sure the irq-ressource is always [1]? (Similar question for the
> >if()-block above). Try platform_get_irq().
>
> I wasn't aware about platform_get_irq. You are right.
>
> What "if()-block above" are you talking about?
The one I quoted: if (pdev->num_resources > 1)
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-04-18 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 9:41 [PATCH v2] uio/pdrv_genirq: Add OF support Michal Simek
2011-04-14 16:59 ` Wolfram Sang
[not found] ` <20110414165931.GA19228-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-04-18 8:33 ` Michal Simek
2011-04-18 15:25 ` Wolfram Sang [this message]
2011-04-14 23:06 ` Hans J. Koch
2011-04-17 17:53 ` Arnd Bergmann
[not found] ` <201104171953.42440.arnd-r2nGTMty4D4@public.gmane.org>
2011-04-17 18:08 ` Hans J. Koch
2011-04-18 8:47 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418152551.GB23814@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hjk@hansjkoch.de \
--cc=john.williams@petalogix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).