devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: jobhunts02-YDxpq3io04c@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: Mistake in p2020rdb.dts?
Date: Tue, 19 Apr 2011 11:04:22 -0500	[thread overview]
Message-ID: <20110419110422.0c41e637@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <D1C1C6B1-BA4D-401E-BC13-2681A024825A-YDxpq3io04c@public.gmane.org>

On Tue, 19 Apr 2011 00:12:59 -0700
<jobhunts02@aol.com> wrote:

> I am running Linux 2.6.32 on a P2020 and am trying to use the kernel’s DMA code. So far, I have had no success.  Is there a mistake in linux/arch/powerc/boot/dts/p2020rdb.dts?
>  
> According to linux/Documentation/powerpc/dts-bindings/fsl/dma.txt, the compatible lists for DMA controllers and the DMA channel nodes should have “2 entries, first is ‘fsl,CHIP-dma’, where CHIP is the processor (mpc8349, mpc8360, etc.) and the second is ‘fsl,elo-dma.’”  In p2020rdb.dts, the compatible lists for the DMA controller and the DMA channel nodes are "fsl,eloplus-dma" and "fsl,eloplus-dma-channel," respectively.  Note that each has only one entry.
>  
> Should compatible = “fsl,P2020RDB-dma”, "fsl,eloplus-dma"  for the DMA controllers?, and
> Should compatible = “fsl,P2020RDB-dma”, " fsl,eloplus-dma-channel"  for the DMA channel nodes?

P2020RDB is not a chip, it's a board.  Plus, we usually use lowercase for
this.

compatible should be "fsl,p2020-dma", "fsl,eloplus-dma", and likewise for
the channels.

-Scott

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

      parent reply	other threads:[~2011-04-19 16:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19  7:12 Mistake in p2020rdb.dts? jobhunts02-YDxpq3io04c
     [not found] ` <D1C1C6B1-BA4D-401E-BC13-2681A024825A-YDxpq3io04c@public.gmane.org>
2011-04-19 16:04   ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110419110422.0c41e637@schlenkerla.am.freescale.net \
    --to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=jobhunts02-YDxpq3io04c@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).