Re: [PATCH] libfdt: include version number in soname

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote:
> On 04/26/2011 12:45 PM, David Gibson wrote:
> > Minimally, yes.  But I think we can do a bit better.  In particular
> > I'd prefer not to tie the soname directly to the dtc version at all.
> > Updates to dtc are only vaguely in sync with libfdt updates, and since
> > we are symbol versioning in libfdt, even pretty significant changes in
> > libfdt won't break backwards compatibility if we do things right.
> > 
> > So here's my patch version instead.  Jon, please apply.
> > 
> > libfdt: include version number in soname
> > 
> > From: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > 
> > The libfdt shared library is only installed by its unversioned name.
> > Including it properly in a distribution requires installation of both
> > the versioned name (used in the binary-only package) and the unversioned
> > name (used in the development package).  The latter is just a symbolic
> > link, so you need to change the soname in turn to include the version.
> > 
> > While at it, use Makefile variables to shorten some lines and avoid
> > cut-and-paste typos; and clean up remnants of when shared libraries were
> > not supported on Darwin.
> > 
> > Signed-off-by: Paolo Bonzini<pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Signed-off-by: David Gibson<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> 
> This:
> 
> +	$(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^
> 
> should be $(LIBFDT_soname).

Ugh, yes, instead of $(LIBFDT_SONAME) to be clear.  I did check the
soname on my build, I must have made an accidental press of M-u after
I did so, sorry.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson