From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH] libfdt: include version number in soname Date: Wed, 27 Apr 2011 01:19:12 +1000 Message-ID: <20110426151912.GE6263@yookeroo> References: <1303380829-16965-1-git-send-email-pbonzini@redhat.com> <20110425030733.GA6263@yookeroo> <4DB5B8D0.90802@redhat.com> <20110426104527.GC6263@yookeroo> <4DB6A98B.6020107@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4DB6A98B.6020107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Paolo Bonzini Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Apr 26, 2011 at 01:16:27PM +0200, Paolo Bonzini wrote: > On 04/26/2011 12:45 PM, David Gibson wrote: > > Minimally, yes. But I think we can do a bit better. In particular > > I'd prefer not to tie the soname directly to the dtc version at all. > > Updates to dtc are only vaguely in sync with libfdt updates, and since > > we are symbol versioning in libfdt, even pretty significant changes in > > libfdt won't break backwards compatibility if we do things right. > > > > So here's my patch version instead. Jon, please apply. > > > > libfdt: include version number in soname > > > > From: Paolo Bonzini > > > > The libfdt shared library is only installed by its unversioned name. > > Including it properly in a distribution requires installation of both > > the versioned name (used in the binary-only package) and the unversioned > > name (used in the development package). The latter is just a symbolic > > link, so you need to change the soname in turn to include the version. > > > > While at it, use Makefile variables to shorten some lines and avoid > > cut-and-paste typos; and clean up remnants of when shared libraries were > > not supported on Darwin. > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: David Gibson > > This: > > + $(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(LIBFDT_SONAME) -o $(LIBFDT_lib) $^ > > should be $(LIBFDT_soname). Ugh, yes, instead of $(LIBFDT_SONAME) to be clear. I did check the soname on my build, I must have made an accidental press of M-u after I did so, sorry. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson