From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv3] ARM:boot:device tree: Allow the device tree binary to be appended to zImage Date: Wed, 27 Apr 2011 07:23:06 -0700 Message-ID: <20110427142306.GI3755@atomide.com> References: <20110324231830.2586.7150.stgit@riker> <20110328091259.GA18721@S2100-06.ap.freescale.net> <20110413140030.GE12665@atomide.com> <20110420054746.GA31127@S2100-06.ap.freescale.net> <20110420073445.GB31127@S2100-06.ap.freescale.net> <20110421080238.GE13688@atomide.com> <20110421124618.GA15060@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20110421124618.GA15060@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Shawn Guo Cc: devicetree-discuss@lists.ozlabs.org, glikely@secretlab.ca, linux-arm-kernel@lists.infradead.org, Nicolas Pitre List-Id: devicetree@vger.kernel.org * Tony Lindgren [110421 05:44]: > * Tony Lindgren [110421 11:00]: > > * Shawn Guo [110420 00:27]: > > > On Wed, Apr 20, 2011 at 01:47:47PM +0800, Shawn Guo wrote: > > > > I would like to confirm it fixes your setup before I send fixing > > > > patch to remove 'static' from global variables in all platform > > > > uncompress.h. > > > > > > > Just saw Nico's patch, so ignore above lines ... > > > > Thanks looks like removing static only changes things so now > > "Warning: Neither atags nor dtb found" error message printed out. > > But also Nico's patch fixes the corruption of the DT data during > uncompress, so I'm getting much further now. > > Now the problem is that the DT data is zeroed out by the time code > gets to setup_machine_fdt. I wonder if I'm missing some patch? > > I'm using grant's devicetree/arm branch + DT append patch + Nico's > static fix + my relocate fix. > > Oh well have to look at it again next week.. I guess the issue is that when setup_machine_fdt gets called we only have minimal MMU mapping done. So I guess there's some other patch related to it? Tony