From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hans J. Koch" Subject: Re: [PATCH v4] uio/pdrv_genirq: Add OF support Date: Wed, 4 May 2011 00:14:40 +0200 Message-ID: <20110503221440.GB2737@local> References: <1304319115-32745-1-git-send-email-monstr@monstr.eu> <20110503203412.GA2119@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20110503203412.GA2119-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Wolfram Sang Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org, john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, May 03, 2011 at 10:34:12PM +0200, Wolfram Sang wrote: > On Mon, May 02, 2011 at 08:51:55AM +0200, Michal Simek wrote: > > Adding OF binding to genirq. > > Version string is setup to the "devicetree". > > > > Compatible string is not setup for now but you can add your > > custom compatible string to uio_of_genirq_match structure. > > > > For example with "vendor,device" compatible string: > > static const struct of_device_id __devinitconst uio_of_genirq_match[] = { > > { .compatible = "vendor,device", }, > > { /* empty for now */ }, > > }; > > > > Signed-off-by: Michal Simek > > [...] > > > + /* alloc uioinfo for one device */ > > + uioinfo = kzalloc(sizeof(*uioinfo), GFP_KERNEL); > > kfree in remove? Oh yes. Missed that one. It should probably look like the "bad0" case in probe(). Thanks, Hans