devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 3/6] MIPS: Octeon: Add device tree source files.
Date: Fri, 27 May 2011 14:13:45 -0600	[thread overview]
Message-ID: <20110527201345.GC6645@ponder.secretlab.ca> (raw)
In-Reply-To: <4DDFD892.1040309@caviumnetworks.com>

On Fri, May 27, 2011 at 10:00:02AM -0700, David Daney wrote:
> On 05/26/2011 06:56 PM, Grant Likely wrote:
> >>+- #interrupt-cells: Must be<2>.  The first cell is the GPIO pin
> >>+   connected to the interrupt source.  The second cell is the interrupt
> >>+   triggering protocol and may have one of four values:
> >>+   0 - level triggered active high.
> >>+   1 - level triggered active low
> >>+   2 - edge triggered on the rising edge.
> >>+   3 - edge triggered on the falling edge.
> >
> >Since you're choosing arbitrary values here anyway, it's convenient to
> >follow the lead of include/linux/irq.h and using 1->edge rising,
> >2->edge falling, 4->level high, 8->level low.  In the past every irq
> >controller kind of did it's own thing, but that's not very scalable.
> >
> 
> OK.  I will use those still somewhat arbitrary values instead.

Indeed, they are still completely arbitrary, but at least they are the
same completely arbitrary values.  :-)

g.

  reply	other threads:[~2011-05-27 20:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 22:25 [RFC PATCH v4 0/6] MIPS: Octeon: Use Device Tree David Daney
     [not found] ` <1305930343-31259-1-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2011-05-20 22:25   ` [RFC PATCH v4 1/6] of: Allow scripts/dtc/libfdt to be used from kernel code David Daney
     [not found]     ` <1305930343-31259-2-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2011-05-21  6:33       ` David Gibson
2011-05-23 16:47         ` David Daney
     [not found]           ` <4DDA8FBC.1090904-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2011-05-27  3:24             ` David Gibson
     [not found]               ` <20110527032402.GD7793-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-05-27 16:49                 ` David Daney
2011-05-27 20:12                   ` Grant Likely
2011-05-20 22:25   ` [RFC PATCH v4 2/6] of: Make of_find_node_by_path() traverse /aliases for relative paths David Daney
     [not found]     ` <1305930343-31259-3-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2011-05-27  2:48       ` Grant Likely
2011-05-20 22:25   ` [RFC PATCH v4 3/6] MIPS: Octeon: Add device tree source files David Daney
2011-05-27  1:56     ` Grant Likely
     [not found]       ` <20110527015618.GC5032-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-05-27 17:00         ` David Daney
2011-05-27 20:13           ` Grant Likely [this message]
2011-05-20 22:25   ` [RFC PATCH v4 4/6] MIPS: Prune some target specific code out of prom.c David Daney
     [not found]     ` <1305930343-31259-5-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2011-05-27  1:58       ` Grant Likely
2011-05-27 17:05         ` David Daney
2011-05-20 22:25   ` [RFC PATCH v4 5/6] MIPS: Octeon: Add irq_create_of_mapping() and GPIO interrupts David Daney
2011-05-20 22:25   ` [RFC PATCH v4 6/6] MIPS: Octeon: Initialize and fixup device tree David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110527201345.GC6645@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=ddaney@caviumnetworks.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).