From: Grant Likely <grant.likely@secretlab.ca>
To: Felipe Balbi <balbi@ti.com>
Cc: devicetree-discuss@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: address: use resource_size helper
Date: Tue, 7 Jun 2011 13:19:42 -0600 [thread overview]
Message-ID: <20110607191942.GB2035@ponder.secretlab.ca> (raw)
In-Reply-To: <1307472924-10907-1-git-send-email-balbi@ti.com>
On Tue, Jun 07, 2011 at 09:55:24PM +0300, Felipe Balbi wrote:
> that should be the approved way of calculating
> the size of resources. No functional changes.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Applied, thanks.
g.
> ---
> drivers/of/address.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index deefc0c..6e7b2cf 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -624,6 +624,6 @@ void __iomem *of_iomap(struct device_node *np, int index)
> if (of_address_to_resource(np, index, &res))
> return NULL;
>
> - return ioremap(res.start, 1 + res.end - res.start);
> + return ioremap(res.start, resource_size(&res));
> }
> EXPORT_SYMBOL(of_iomap);
> --
> 1.7.6.rc0
>
prev parent reply other threads:[~2011-06-07 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 18:55 [PATCH] of: address: use resource_size helper Felipe Balbi
2011-06-07 19:19 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607191942.GB2035@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).