From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 3/3] ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss Date: Mon, 13 Jun 2011 03:47:57 -0700 Message-ID: <20110613104757.GE10951@atomide.com> References: <1307858800-16712-1-git-send-email-nicolas.pitre@linaro.org> <1307858800-16712-4-git-send-email-nicolas.pitre@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1307858800-16712-4-git-send-email-nicolas.pitre@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Nicolas Pitre Cc: John Bonesio , Grant Likely , devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org * Nicolas Pitre [110611 23:03]: > The appended DTB gets relocated with the decompressor code to get out > of the way of the decompressed kernel. However the .bss section may > be larger than the relocated code and data, therefore overwriting the > DTB. Let's make sure the relocation takes care of moving zImage so > no conflict with .bss occurs. > > Thanks to Tony Lindgren for figuring out this issue. > > While at it, let's clean up the code a bit so that the wont_overwrite > symbol is used while determining if a conflict exists, making the above > change more precise as well as eliminating some ARM/THUMB alternates. > > Signed-off-by: Nicolas Pitre Great, this simplifies things: Acked-by: Tony Lindgren