From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: Make sure appended device tree data won't overlap kernel BSS Date: Mon, 13 Jun 2011 03:49:41 -0700 Message-ID: <20110613104940.GF10951@atomide.com> References: <20110429135334.GR5126@n2100.arm.linux.org.uk> <20110504072317.GU2092@atomide.com> <20110509111929.GA11410@atomide.com> <20110509144949.GE30958@atomide.com> <20110512125952.GN31483@atomide.com> <20110513112120.GO31483@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Nicolas Pitre Cc: glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Russell King - ARM Linux , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org * Nicolas Pitre [110611 23:09]: > On Fri, 13 May 2011, Tony Lindgren wrote: > > > From: Tony Lindgren > > Date: Thu, 12 May 2011 05:29:49 -0700 > > Subject: [PATCH] ARM: zImage: Make sure appended device tree data won't overlap kernel BSS > > > > Do this before relocating the compressed kernel + device tree data. > > Otherwise we would have to split the copying into two parts, or copy > > the device tree data twice. > > > > As we only have one register available, pass the size of kernel BSS > > via linker and do the calculation using r1, then save it to the stack. > > > > Note that this patch now makes the stack also usable earlier for > > CONFIG_ARM_APPENDED_DTB. > > > > Signed-off-by: Tony Lindgren > [...] > > Please tell me what you think of this alternative: > http://article.gmane.org/gmane.linux.ports.arm.kernel/120182 > I think it is a cleaner solution. Yeah that's nice, I acked that one in the thread. Regards, Tony