From: Grant Likely <grant.likely@secretlab.ca>
To: Tony Lindgren <tony@atomide.com>
Cc: "G, Manjunath Kondaiah" <manjugk@ti.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
ben-linux@fluff.org
Subject: Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board
Date: Wed, 6 Jul 2011 12:49:49 -0600 [thread overview]
Message-ID: <20110706184949.GI4871@ponder.secretlab.ca> (raw)
In-Reply-To: <20110630142702.GV23145@atomide.com>
On Thu, Jun 30, 2011 at 07:27:02AM -0700, Tony Lindgren wrote:
> Hi,
>
> Few comments on the .dts data layout below.
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [110630 02:44]:
> > --- a/arch/arm/boot/dts/omap3-beagle-nunchuck.dts
> > +++ b/arch/arm/boot/dts/omap3-beagle-nunchuck.dts
> > @@ -2,11 +2,6 @@
> >
> > / {
> > i2c@48072000 {
> > - compatible = "ti,omap3-i2c";
> > - reg = <0x48072000 0x80>;
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > -
> > eeprom@50 {
> > compatible = "at,at24c01";
> > reg = < 0x50 >;
>
> The board .dts file should include the omap3 SoC .dts file.
>
> The omap3 SoC .dts file should have the devices mapped to L3 and L4
> busses, and the then i2c@1 would just contain the bus offset.
>
> Then the i2c@1 entry would be repeated in the board specific
> .dts and tell that the i2c@1 is enabled.
yup.
next prev parent reply other threads:[~2011-07-06 18:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 10:07 [RFC PATCH 0/5] OMAP: I2C: Add device tree support G, Manjunath Kondaiah
2011-06-30 10:07 ` [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board G, Manjunath Kondaiah
2011-06-30 14:27 ` Tony Lindgren
2011-07-06 18:49 ` Grant Likely [this message]
2011-07-06 18:55 ` Grant Likely
2011-07-06 23:26 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF049E21C203-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-07-07 0:12 ` Grant Likely
[not found] ` <CACxGe6u8qq7FA7kFXbU5uCk6m_GA8GWLqsdjFCXN+NMJfFKxmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-20 11:04 ` Shawn Guo
[not found] ` <20110720110419.GA6999-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-20 18:55 ` Grant Likely
[not found] ` <20110720185513.GI4642-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-07-20 22:33 ` Shawn Guo
[not found] ` <20110720223348.GH6999-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-20 23:14 ` Grant Likely
2011-06-30 10:07 ` [RFC PATCH 2/5] OMAP4:I2C: Add device tree nodes for panda board G, Manjunath Kondaiah
2011-07-06 18:57 ` Grant Likely
2011-07-07 16:59 ` G, Manjunath Kondaiah
2011-06-30 10:07 ` [RFC PATCH 3/5] OMAP3: Beagle: Update beagle board file to use DT G, Manjunath Kondaiah
2011-07-06 19:00 ` Grant Likely
2011-07-07 17:04 ` G, Manjunath Kondaiah
2011-06-30 10:07 ` [RFC PATCH 4/5] OMAP4: Panda: Update panda " G, Manjunath Kondaiah
2011-07-06 19:01 ` Grant Likely
2011-06-30 10:07 ` [RFC PATCH 5/5] OMAP: I2C: Convert I2C driver to use device tree G, Manjunath Kondaiah
2011-07-06 19:08 ` Grant Likely
2011-07-07 17:13 ` G, Manjunath Kondaiah
2011-07-07 18:28 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706184949.GI4871@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).