devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Tabi Timur-B04825 <B04825-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Guo Shawn-R65073 <r65073-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: Is there a binding for IORESOURCE_DMA population?
Date: Sun, 17 Jul 2011 22:39:40 -0600	[thread overview]
Message-ID: <20110718043940.GD15023@ponder.secretlab.ca> (raw)
In-Reply-To: <4E22E66D.5010809-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

On Sun, Jul 17, 2011 at 01:41:02PM +0000, Tabi Timur-B04825 wrote:
> Shawn Guo wrote:
> >> >
> > Between a) making DT enabled SSI driver (mpc version) work for i.mx
> > and b) adding DT probe support for imx-ssi driver, I would absolutely
> > go for b).  Apparently it's much easier.
> 
> Absolutely not!  It's ridiculous to have two drivers for the same exact 
> device that are both device-tree enabled.  It's already bad enough that we 
> have fsl-ssi.c and imx-ssi.c.  imx-ssi.c should never have been created, 
> but there's no way I will approve enhancing imx-ssi.c to also support 
> device trees, when fsl-ssi.c already does this.

I would disagree here.  I absolutely do think that the drivers should
be consolidated if they are the same device, but until someone
actually steps up to do that work, and as long as the current drivers
use different interfaces, then I have no problem adding the DT
bindings to the imx-ssi.c driver.

That said, since the fsl-ssi.c driver already implements a DT binding,
the imx driver definitely should implement the same binding unless
there is a really strong technical reason not to.

g.

  parent reply	other threads:[~2011-07-18  4:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15 16:32 Is there a binding for IORESOURCE_DMA population? Shawn Guo
     [not found] ` <20110715163254.GG1840-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-15 16:45   ` Tabi Timur-B04825
     [not found]     ` <CAOZdJXVeM4Axf=TC4qKNHyqb=iDoDceGr-xjLNpD20WfL2h46Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-15 18:11       ` Arnd Bergmann
     [not found]         ` <201107152011.41546.arnd-r2nGTMty4D4@public.gmane.org>
2011-07-15 23:49           ` Grant Likely
2011-07-16  7:57           ` Shawn Guo
     [not found]             ` <20110716075748.GI1840-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-16 12:09               ` Arnd Bergmann
     [not found]                 ` <201107161409.46719.arnd-r2nGTMty4D4@public.gmane.org>
2011-07-16 12:55                   ` Tabi Timur-B04825
     [not found]                     ` <4E218A4C.8000603-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-16 14:40                       ` Shawn Guo
     [not found]                         ` <20110716144026.GB2374-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-16 14:38                           ` Tabi Timur-B04825
     [not found]                             ` <4E21A252.4060606-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-17  7:18                               ` Shawn Guo
2011-07-16 19:16                           ` Rob Herring
     [not found]                             ` <4E21E398.4060808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-07-17  7:30                               ` Shawn Guo
2011-07-16 20:18                           ` Tabi Timur-B04825
     [not found]                             ` <4E21F22C.3020804-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-16 20:44                               ` Arnd Bergmann
     [not found]                                 ` <201107162244.47740.arnd-r2nGTMty4D4@public.gmane.org>
2011-07-16 20:54                                   ` Tabi Timur-B04825
     [not found]                                     ` <4E21FA7C.2000602-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-17  7:38                                       ` Shawn Guo
2011-07-16 14:34                   ` Shawn Guo
     [not found]                     ` <20110716143456.GA2374-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-16 14:43                       ` Tabi Timur-B04825
     [not found]                         ` <4E21A392.3010608-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-17  7:41                           ` Shawn Guo
     [not found]                             ` <20110717074159.GF2374-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-17 13:41                               ` Tabi Timur-B04825
     [not found]                                 ` <4E22E66D.5010809-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-17 14:28                                   ` Shawn Guo
     [not found]                                     ` <20110717142838.GI2374-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-17 14:57                                       ` Tabi Timur-B04825
     [not found]                                         ` <4E22F867.5090707-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-17 15:47                                           ` Shawn Guo
     [not found]                                             ` <20110717154730.GK2374-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-07-17 16:04                                               ` Tabi Timur-B04825
     [not found]                                                 ` <4E230802.9030805-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-19 15:16                                                   ` Arnd Bergmann
     [not found]                                                     ` <201107191716.56203.arnd-r2nGTMty4D4@public.gmane.org>
2011-07-20  2:53                                                       ` Shawn Guo
2011-07-17 15:04                                       ` Arnd Bergmann
     [not found]                                         ` <201107171704.17779.arnd-r2nGTMty4D4@public.gmane.org>
2011-07-17 15:41                                           ` Shawn Guo
2011-07-18  4:39                                   ` Grant Likely [this message]
     [not found]                                     ` <20110718043940.GD15023-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-07-18 11:19                                       ` Tabi Timur-B04825
2011-07-16 15:19                       ` Arnd Bergmann
     [not found]                         ` <201107161719.32543.arnd-r2nGTMty4D4@public.gmane.org>
2011-07-16 15:27                           ` Tabi Timur-B04825
     [not found]                             ` <4E21ADC5.5010205-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-16 17:33                               ` Arnd Bergmann
2011-07-17  8:02                               ` Shawn Guo
2011-07-17  7:59                           ` Shawn Guo
2011-07-18  4:34                   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110718043940.GD15023@ponder.secretlab.ca \
    --to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
    --cc=B04825-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=r65073-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).