Re: [PATCH] Various fixups from first bug reports

Re: [PATCH] Various fixups from first bug reports

[Uwe Kleine-König]

Hello,

(These two issues occured on 3.0-rc7-rt0, I think they apply to
mainline, too.)

On Fri, Jul 22, 2011 at 07:43:34AM +0200, hermann wrote:
> well, I run into 2 ops, witch, I guess not related to the rt patch.
> 
> first one was with CONFIG_SENSORS_LTC4245, module build stage 2 failed
> with undefined reference to of_find_property
of_find_property isn't exported to modules. Maybe of_get_property should
be used? Should of_find_property be static then? Alternatively export
of_find_property, too. Grant?

> second was with CONFIG_LGUEST_GUEST enabled, module build stage 2 failed
> with Documentation/lguest not found
Hmm, there is Documentation/virtual/lguest. Didn't find where
Documentation/lguest is used from a quick look. Rusty?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Various fixups from first bug reports

[hermann]

Am Freitag, den 22.07.2011, 08:57 +0200 schrieb Uwe Kleine-König:
> > second was with CONFIG_LGUEST_GUEST enabled, module build stage 2
> failed
> > with Documentation/lguest not found
> Hmm, there is Documentation/virtual/lguest. Didn't find where
> Documentation/lguest is used from a quick look. Rusty?
> 
> Best regards
> Uwe 

Sorry, I'm far from being a expert, all I can say is that disable 
CONFIG_LGUEST and
CONFIG_LGUEST_GUEST also (auto)disable
CONFIG_PARAVIRT_SPINLOCKS
and then it works, at least here.

regards
hermann

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Various fixups from first bug reports

[Rusty Russell]

On Fri, 22 Jul 2011 08:57:11 +0200, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Hello,
> 
> (These two issues occured on 3.0-rc7-rt0, I think they apply to
> mainline, too.)
> 
> On Fri, Jul 22, 2011 at 07:43:34AM +0200, hermann wrote:
> > well, I run into 2 ops, witch, I guess not related to the rt patch.
> > 
> > first one was with CONFIG_SENSORS_LTC4245, module build stage 2 failed
> > with undefined reference to of_find_property
> of_find_property isn't exported to modules. Maybe of_get_property should
> be used? Should of_find_property be static then? Alternatively export
> of_find_property, too. Grant?
> 
> > second was with CONFIG_LGUEST_GUEST enabled, module build stage 2 failed
> > with Documentation/lguest not found
> Hmm, there is Documentation/virtual/lguest. Didn't find where
> Documentation/lguest is used from a quick look. Rusty?

No, it's not compiled from the kernel build, at least in mainline...

If it is in the -r tree, you need to
s,Documentation/lguest,Documentation/virtual/lguest, as it has moved.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Various fixups from first bug reports

[Uwe Kleine-König]

Hello,

On Fri, Jul 22, 2011 at 08:34:59PM +0930, Rusty Russell wrote:
> On Fri, 22 Jul 2011 08:57:11 +0200, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > > second was with CONFIG_LGUEST_GUEST enabled, module build stage 2 failed
> > > with Documentation/lguest not found
> > Hmm, there is Documentation/virtual/lguest. Didn't find where
> > Documentation/lguest is used from a quick look. Rusty?
> 
> No, it's not compiled from the kernel build, at least in mainline...
> 
> If it is in the -r tree, you need to
> s,Documentation/lguest,Documentation/virtual/lguest, as it has moved.
I don't understand that and didn't try to reproduce. 
hermann, maybe you can follow up with your failing .config and try to
reproduce on v3.0 (without rt)?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] Various fixups from first bug reports

[hermann]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

Am Freitag, den 22.07.2011, 21:20 +0200 schrieb Uwe Kleine-König:
> I don't understand that and didn't try to reproduce. 
> hermann, maybe you can follow up with your failing .config and try to
> reproduce on v3.0 (without rt)?
> 
> Best regards
> Uwe 

well, it also didn't build from the 3.0 mainline with that config. After
modules build stage 2, it comes to :
. . . . .
IHEX    firmware/yam/9600.bin
make[1]: Leaving directory `/home/brummer/Projekte/Kernel/linux-3.0'
/usr/bin/make    ARCH=i386 \
			     -C Documentation/lguest
make: *** Documentation/lguest: Datei oder Verzeichnis nicht gefunden.
Schluss.
make: *** [debian/stamp/build/kernel] Fehler 2

[Datei oder Verzeichnis nicht gefunden == file or directory not found
Schlusss == exit
Fehler 2 == error 2]

attached is the config. 

regards
hermann

[-- Attachment #2: .config.bz2 --]
[-- Type: application/x-bzip, Size: 28228 bytes --]

Re: [PATCH] Various fixups from first bug reports

[Robin Gareus]

On 07/23/2011 05:17 AM, hermann wrote:
> Am Freitag, den 22.07.2011, 21:20 +0200 schrieb Uwe Kleine-König:
>> I don't understand that and didn't try to reproduce. 
>> hermann, maybe you can follow up with your failing .config and try to
>> reproduce on v3.0 (without rt)?
>>
>> Best regards
>> Uwe 
> 
> well, it also didn't build from the 3.0 mainline with that config. After
> modules build stage 2, it comes to :
> . . . . .
> IHEX    firmware/yam/9600.bin
> make[1]: Leaving directory `/home/brummer/Projekte/Kernel/linux-3.0'
> /usr/bin/make    ARCH=i386 \
> 			     -C Documentation/lguest
> make: *** Documentation/lguest: Datei oder Verzeichnis nicht gefunden.
> Schluss.
> make: *** [debian/stamp/build/kernel] Fehler 2
> 
Hello Herman,

Are you using make-kpkg?  You need to change the path to lguest
in /usr/share/kernel-package/ruleset/targets/doc.mk and two or three
other files there as Rusty outlined.

HTH,
robin
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Various fixups from first bug reports

[hermann]

Am Samstag, den 23.07.2011, 11:57 +0200 schrieb Robin Gareus:
> Hello Herman,
> 
> Are you using make-kpkg?  You need to change the path to lguest
> in /usr/share/kernel-package/ruleset/targets/doc.mk and two or three
> other files there as Rusty outlined.
> 
> HTH,
> robin 

Hi Robin

Yes, using make-kpkg. I changed line 61 from 

rm -f $(DOCDIR)/Documentation/lguest/lguest
$(DOCDIR)/Documentation/lguest/lguest.lds

to 

rm -f $(DOCDIR)/Documentation/virtual/lguest/lguest
$(DOCDIR)/Documentation/virtual/lguest/lguest.lds

but it didn't help, the result is still the same.
/usr/bin/make    ARCH=i386 \
			     -C Documentation/lguest
make: *** Documentation/lguest: Datei oder Verzeichnis nicht gefunden.
Schluss.

Could you wrote a bit more precise what needs to do, please ?

regards
hermann

Re: [PATCH] Various fixups from first bug reports

[Robin Gareus]

On 07/23/2011 04:19 PM, hermann wrote:
> Am Samstag, den 23.07.2011, 11:57 +0200 schrieb Robin Gareus:
>> Hello Herman,
>>
>> Are you using make-kpkg?  You need to change the path to lguest
>> in /usr/share/kernel-package/ruleset/targets/doc.mk and two or three
>> other files there as Rusty outlined.
>>
>> HTH,
>> robin 
> 
> Hi Robin
> 
> Yes, using make-kpkg. I changed line 61 from 
> [..]
> but it didn't help, the result is still the same.
> /usr/bin/make    ARCH=i386 \
> 			     -C Documentation/lguest

That's the one in /usr/share/kernel-package/ruleset/targets/image.mk

I don't remember all locations, there were around a dozen, also
including some $CONFIG_* checks. It was pretty straight forward and -
alas - I did not keep a diff.

`grep -rli lguest /usr/share/kernel-package/` should get you going.

If you're really stuck I can `apt-get --reinstall` and create a diff.
Let me know. If it is Debian, be aware that there are also various other
scripts in need of patching (e.g. /etc/init.d/udev supported_kernel()
does not match the 3.X series, yet),..


> Schluss.
ende, aus :)

robin

Re: [PATCH] Various fixups from first bug reports

[hermann]

Am Samstag, den 23.07.2011, 16:33 +0200 schrieb Robin Gareus:
> On 07/23/2011 04:19 PM, hermann wrote:
> > Am Samstag, den 23.07.2011, 11:57 +0200 schrieb Robin Gareus:
> >> Hello Herman,
> >>
> >> Are you using make-kpkg?  You need to change the path to lguest
> >> in /usr/share/kernel-package/ruleset/targets/doc.mk and two or three
> >> other files there as Rusty outlined.
> >>
> >> HTH,
> >> robin 
> > 
> > Hi Robin
> > 
> > Yes, using make-kpkg. I changed line 61 from 
> > [..]
> > but it didn't help, the result is still the same.
> > /usr/bin/make    ARCH=i386 \
> > 			     -C Documentation/lguest
> 
> That's the one in /usr/share/kernel-package/ruleset/targets/image.mk
> 
> I don't remember all locations, there were around a dozen, also
> including some $CONFIG_* checks. It was pretty straight forward and -
> alas - I did not keep a diff.
> 
> `grep -rli lguest /usr/share/kernel-package/` should get you going.
> 
> If you're really stuck I can `apt-get --reinstall` and create a diff.
> Let me know. If it is Debian, be aware that there are also various other
> scripts in need of patching (e.g. /etc/init.d/udev supported_kernel()
> does not match the 3.X series, yet),..
> 
> 
> > Schluss.
> ende, aus :)
> 
> robin

Thanks robin, get it working now. Have changed the locations in 
/usr/share/kernel-package/ruleset/targets/common.mk
/usr/share/kernel-package/ruleset/targets/doc.mk
/usr/share/kernel-package/ruleset/targets/image.mk

It would be cool if you could remember witch other scripts need to be
patched to support the 3.X series.

I mean I run already the Kernel 3.0.0-rc7-rt0 i686 here on debian/sid
without hazel, but be interested to set up all in a matching manner.  

regards
hermann

Re: [PATCH] Various fixups from first bug reports

[Uwe Kleine-König]

Hello,

On Sat, Jul 23, 2011 at 04:19:13PM +0200, hermann wrote:
> Am Samstag, den 23.07.2011, 11:57 +0200 schrieb Robin Gareus:
> Yes, using make-kpkg. I changed line 61 from 
there is an alternative,

	make deb-pkg

in the vanilla kernel. Depending on why you use make-kpkg it might be
worth a try.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html