Re: [PATCH] ASoC: sgtl5000: add device tree probe support

[Grant Likely <grant.likely@secretlab.ca>]

On Tue, Jul 26, 2011 at 08:55:11PM +0100, Mark Brown wrote:
> On Fri, Jul 22, 2011 at 12:28:51AM +0800, Shawn Guo wrote:
> 
> > It adds device tree probe support for sgtl5000 driver.
> 
> Kind of waiting for the device tree people to comment on this...
> 
> >  .../bindings/sound/soc/codecs/fsl-sgtl5000.txt     |   11 +++++++++++
> 
> I'd expect this can just be put directly under the sound directory.
> 
> > +++ b/Documentation/devicetree/bindings/sound/soc/codecs/fsl-sgtl5000.txt
> > @@ -0,0 +1,11 @@
> > +* Freescale SGTL5000 Stereo Codec
> > +
> > +Required properties:
> > +- compatible : "fsl,sgtl5000".
> > +
> > +Example:
> > +
> > +codec: sgtl5000@0a {
> > +	compatible = "fsl,sgtl5000";
> > +	reg = <0x0a>;
> > +};
> 
> This might get a tiny bit verbose...  I wonder if it makes sense to have
> some central file for devices with trivial bindings?  But possibly more
> trouble than it's worth.

Yes, I think it would be valuable.  I've been thinking a lot about how
to make binding documentation less verbose and have much better cross
referencing so that binding documentation doesn't need to include all
kinds of common property definitions. I've had no time to work on
it though... I need an intern student.  :-)

g.