From: Grant Likely <grant.likely@secretlab.ca>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: alsa-devel@alsa-project.org, patches@linaro.org,
devicetree-discuss@lists.ozlabs.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Zeng Zhaoming <zhaoming.zeng@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: sgtl5000: add device tree probe support
Date: Fri, 29 Jul 2011 10:00:48 -0600 [thread overview]
Message-ID: <20110729160048.GG11164@ponder.secretlab.ca> (raw)
In-Reply-To: <20110729024050.GD1946@S2100-06.ap.freescale.net>
On Fri, Jul 29, 2011 at 10:40:51AM +0800, Shawn Guo wrote:
> On Tue, Jul 26, 2011 at 08:55:11PM +0100, Mark Brown wrote:
> > On Fri, Jul 22, 2011 at 12:28:51AM +0800, Shawn Guo wrote:
> >
> > > It adds device tree probe support for sgtl5000 driver.
> >
> > Kind of waiting for the device tree people to comment on this...
> >
>
> Grant, please?
Acked-by: Grant Likely <grant.likely@secretlab.ca>
>
> Regards,
> Shawn
>
> > > .../bindings/sound/soc/codecs/fsl-sgtl5000.txt | 11 +++++++++++
> >
> > I'd expect this can just be put directly under the sound directory.
> >
> > > +++ b/Documentation/devicetree/bindings/sound/soc/codecs/fsl-sgtl5000.txt
> > > @@ -0,0 +1,11 @@
> > > +* Freescale SGTL5000 Stereo Codec
> > > +
> > > +Required properties:
> > > +- compatible : "fsl,sgtl5000".
> > > +
> > > +Example:
> > > +
> > > +codec: sgtl5000@0a {
> > > + compatible = "fsl,sgtl5000";
> > > + reg = <0x0a>;
> > > +};
> >
> > This might get a tiny bit verbose... I wonder if it makes sense to have
> > some central file for devices with trivial bindings? But possibly more
> > trouble than it's worth.
> > _______________________________________________
> > devicetree-discuss mailing list
> > devicetree-discuss@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/devicetree-discuss
> >
>
next prev parent reply other threads:[~2011-07-29 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 16:28 [PATCH] ASoC: sgtl5000: add device tree probe support Shawn Guo
[not found] ` <1311265731-23318-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-26 19:55 ` Mark Brown
2011-07-29 2:40 ` Shawn Guo
2011-07-29 16:00 ` Grant Likely [this message]
2011-07-29 16:00 ` Grant Likely
2011-07-29 16:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729160048.GG11164@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=lrg@ti.com \
--cc=patches@linaro.org \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).