Re: [PATCH] dt: remove of_alias_get_id() reference

[Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1394 bytes --]

On Thu, Aug 04, 2011 at 11:30:27AM +0100, Grant Likely wrote:
> of_alias_get_id() is broken and being reverted.  Remove the reference
> to it and replace with a single incrementing id number.
> 
> There is no risk of regression here on the imx driver since the imx
> change to use of_alias_get_id() is commit 22698aa2, "serial/imx: add
> device tree probe support" which is new for v3.1, and it won't get
> used unless CONFIG_OF is enabled and the board is booted using a
> device tree.  A single incrementing integer is sufficient for now.
> 
> Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> 
> I'm about to ask Linus to pull this patch through the devicetree/merge
> branch along with the of_alias revert.
> 
>  drivers/tty/serial/imx.c |   13 ++++---------
>  1 files changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 827db76..7e91b3d 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1286,22 +1286,17 @@ static int serial_imx_resume(struct platform_device *dev)
>  static int serial_imx_probe_dt(struct imx_port *sport,
>  		struct platform_device *pdev)
>  {
> +	static int portnum = 0;

would it be better to use an IDR here ?

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss