From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Daniel Morsing <daniel.morsing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [RFC PATCH] Device tree enable the DM9000 driver
Date: Tue, 9 Aug 2011 14:45:40 -0600 [thread overview]
Message-ID: <20110809204540.GB11568@ponder.secretlab.ca> (raw)
In-Reply-To: <1312919849-4979-1-git-send-email-daniel.morsing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, Aug 09, 2011 at 09:57:28PM +0200, Daniel Morsing wrote:
> This is a first draft for device tree enabling the DM9000 driver.
> The dm9000 is used for a couple of development boards as a low cost ethernet
> controller. Currently there are no users in the kernel, but once support for
> device trees mature on OMAP3, I plan to migrate the Devkit8000 development
> board to DT.
>
> The patch was originally based on 3.0, so it may contain anachronisms.
> First time playing with device trees, so if i've misunderstood
> anything, Sorry :).
>
> Daniel Morsing (1):
> net: dm9000: add support for device tree probing
Nitpick: when there is only one patch in a series, don't use a cover
letter. Put the cover letter text into the patch itself.
>
> Documentation/devicetree/bindings/net/dm9000.txt | 46 ++++++++++++
Regardless of whether you misunderstood something or not, you added
documentation which is already miles ahead. :-)
g.
prev parent reply other threads:[~2011-08-09 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 19:57 [RFC PATCH] Device tree enable the DM9000 driver Daniel Morsing
[not found] ` <1312919849-4979-1-git-send-email-daniel.morsing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-08-09 19:57 ` [RFC PATCH] net: dm9000: add support for device tree probing Daniel Morsing
[not found] ` <1312919849-4979-2-git-send-email-daniel.morsing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-08-09 20:51 ` Grant Likely
[not found] ` <20110809205155.GC11568-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-08-10 11:30 ` Daniel Morsing
2011-08-09 20:45 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809204540.GB11568@ponder.secretlab.ca \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=daniel.morsing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).