From mboxrd@z Thu Jan 1 00:00:00 1970 From: "G, Manjunath Kondaiah" Subject: Re: [RFC/PATCH 04/14] OMAP: McBSP: use existing macros for converting between devices Date: Wed, 10 Aug 2011 21:35:56 +0530 Message-ID: <20110810160556.GB2091@manju-desktop> References: <1312897232-4792-1-git-send-email-manjugk@ti.com> <1312897232-4792-5-git-send-email-manjugk@ti.com> <20110810100704.856fcc5c.jhnikula@gmail.com> <4E425A56.4000605@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4E425A56.4000605@ti.com> Sender: linux-omap-owner@vger.kernel.org To: "Cousson, Benoit" Cc: Jarkko Nikula , "devicetree-discuss@lists.ozlabs.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "grant.likely@secretlab.ca" , "Hilman, Kevin" List-Id: devicetree@vger.kernel.org On Wed, Aug 10, 2011 at 12:15:50PM +0200, Cousson, Benoit wrote: > Manju, > > On 8/10/2011 9:07 AM, Jarkko Nikula wrote: > >Hi > > > >On Tue, 09 Aug 2011 19:10:22 +0500 > >"G, Manjunath Kondaiah" wrote: > > > >>From: Kevin Hilman > >> > >>For converting from struct device to platform_device, and from > >>platform_device to struct device, there are existing macros. Use > >>them instead of manual use of container_of(). > >> > >>Signed-off-by: Kevin Hilman > >>--- > >> arch/arm/plat-omap/mcbsp.c | 6 +++--- > >> 1 files changed, 3 insertions(+), 3 deletions(-) > >> > >Kevin dropped this patch and used mine that does more cleanups: > > > >http://marc.info/?l=linux-omap&m=131255627918065&w=2 > > > >Worth to check also other patches since Kevin's updated set seems to > >have other differences too: > > > >http://marc.info/?l=linux-omap&m=131258997416300&w=2 > > In fact, you'd better point to the lastest Kevin's tree and not > included the patches in this series. Yes. I have already mentioned this in PATCH 00/14 and it will be rebased during rework for review comments. Main focus here is on dt-hwmod binding and omap-i2c dt adaptation. -M